From: Felipe Balbi <balbi@ti.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-usb@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
"Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 2/2] usb: fix renesas_usbhs to not schedule in atomic context
Date: Mon, 13 Feb 2012 14:08:15 +0200 [thread overview]
Message-ID: <20120213120814.GP6614@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1202092316180.18719@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
Hi,
On Thu, Feb 09, 2012 at 11:17:51PM +0100, Guennadi Liakhovetski wrote:
> @@ -997,7 +991,7 @@ static bool usbhsf_dma_filter(struct dma_chan *chan, void *param)
> *
> * usbhs doesn't recognize id = 0 as valid DMA
> */
> - if (0 == slave->slave_id)
> + if (0 == slave->simple_slave.slave_id)
> return false;
>
> chan->private = slave;
> @@ -1176,8 +1170,8 @@ int usbhs_fifo_probe(struct usbhs_priv *priv)
> fifo->port = D0FIFO;
> fifo->sel = D0FIFOSEL;
> fifo->ctr = D0FIFOCTR;
> - fifo->tx_slave.slave_id = usbhs_get_dparam(priv, d0_tx_id);
> - fifo->rx_slave.slave_id = usbhs_get_dparam(priv, d0_rx_id);
> + fifo->tx_slave.simple_slave.slave_id = usbhs_get_dparam(priv, d0_tx_id);
> + fifo->rx_slave.simple_slave.slave_id = usbhs_get_dparam(priv, d0_rx_id);
what are these "simple_slave" changes ? They have nothing to do with
$SUBJECT ? In fact, breaks my gadget branch.
How many times does a maintainer have to ask for contributors to keep
changes atomic ? One patch == One single, self-contained, change.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-13 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.1202092313560.18719@axis700.grange>
2012-02-09 22:17 ` Guennadi Liakhovetski
2012-02-13 12:08 ` Felipe Balbi [this message]
2012-02-13 12:17 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213120814.GP6614@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=g.liakhovetski@gmx.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vinod.koul@intel.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®