From: Matthew Garrett <mjg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, dzickus@redhat.com,
vgoyal@redhat.com, seiji.aguchi@hds.com
Subject: Re: [PATCH V3] kmsg_dump: Don't run on non-error paths by default
Date: Tue, 14 Feb 2012 21:12:32 +0000 [thread overview]
Message-ID: <20120214211232.GB2750@srcf.ucam.org> (raw)
In-Reply-To: <20120214130522.fdb05b81.akpm@linux-foundation.org>
On Tue, Feb 14, 2012 at 01:05:22PM -0800, Andrew Morton wrote:
> So if I'm understanding it correctly, this patch reverts the kernel
> behaviour to what it was before 04c6862c055fb687c9 ("kmsg_dump: add
> kmsg_dump() calls to the reboot, halt, poweroff and emergency_restart
> paths"). The user must now set printk.always_kmsg_dump to get the
> 04c6862c055fb687c9 behaviour.
Correct.
> Correct? If so, we should get this into 3.3 so we don't have a oddball
> behaviour in one particular kernel release.
That would be my preference.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2012-02-14 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 15:45 Matthew Garrett
2012-02-14 19:23 ` Matthew Garrett
2012-02-14 21:05 ` Andrew Morton
2012-02-14 21:12 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214211232.GB2750@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seiji.aguchi@hds.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®