mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Bill Nottingham <notting@redhat.com>
Cc: linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [ibm-acpi-devel] [PATCH] Make 'Thermal Table has changed' a debug message.
Date: Tue, 14 Feb 2012 21:53:13 -0200	[thread overview]
Message-ID: <20120214235313.GD9521@khazad-dum.debian.net> (raw)
In-Reply-To: <1329247829-28099-1-git-send-email-notting@redhat.com>

On Tue, 14 Feb 2012, Bill Nottingham wrote:
> If the recommended action is "do nothing", we shouldn't be cluttering
> the logs with it.
> 
> Signed-off-by: Bill Nottingham <notting@redhat.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

We never figured out what interesting hint the thinkpad was trying to give
us.

> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index ea0c607..a96983e 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3605,7 +3605,7 @@ static bool hotkey_notify_6xxx(const u32 hkey,
>  
>  	switch (hkey) {
>  	case TP_HKEY_EV_THM_TABLE_CHANGED:
> -		pr_info("EC reports that Thermal Table has changed\n");
> +		pr_debug("EC reports that Thermal Table has changed\n");
>  		/* recommended action: do nothing, we don't have
>  		 * Lenovo ATM information */
>  		return true;

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

      reply	other threads:[~2012-02-14 23:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 19:30 Bill Nottingham
2012-02-14 23:53 ` Henrique de Moraes Holschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120214235313.GD9521@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=notting@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®