From: Dong Aisheng <dongas86@gmail.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: Make "hog" mapping table entries work
Date: Tue, 14 Feb 2012 20:38:13 -0800 [thread overview]
Message-ID: <20120215043813.GA3607@b29396-Latitude-E6410> (raw)
In-Reply-To: <1329241841-21357-1-git-send-email-swarren@nvidia.com>
On Tue, Feb 14, 2012 at 10:50:41AM -0700, Stephen Warren wrote:
> Commit 77a5988 "pinctrl: changes hog mechanism to be self-referential"
> modified the way "hog" entries were represented in the mapping table.
> However, the new representation failed some error checks in
> pinctrl_hog_map(). Remove the now-bogus error-check, and fix the code
> to solve the issue the error-check used to avoid.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
Regards
Dong Aisheng
> ---
> drivers/pinctrl/core.c | 14 +-------------
> 1 files changed, 1 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
> index c5f76ad..8a91eb2 100644
> --- a/drivers/pinctrl/core.c
> +++ b/drivers/pinctrl/core.c
> @@ -725,23 +725,11 @@ static int pinctrl_hog_map(struct pinctrl_dev *pctldev,
> struct pinctrl *p;
> int ret;
>
> - if (map->dev_name) {
> - /*
> - * TODO: the day we have device tree support, we can
> - * traverse the device tree and hog to specific device nodes
> - * without any problems, so then we can hog pinmuxes for
> - * all devices that just want a static pin mux at this point.
> - */
> - dev_err(pctldev->dev, "map %s wants to hog a non-system pinmux, this is not going to work\n",
> - map->name);
> - return -EINVAL;
> - }
> -
> hog = kzalloc(sizeof(struct pinctrl_hog), GFP_KERNEL);
> if (!hog)
> return -ENOMEM;
>
> - p = pinctrl_get(NULL, map->name);
> + p = pinctrl_get(pctldev->dev, map->name);
> if (IS_ERR(p)) {
> kfree(hog);
> dev_err(pctldev->dev,
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-02-15 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 17:50 Stephen Warren
2012-02-15 4:38 ` Dong Aisheng [this message]
2012-02-16 18:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215043813.GA3607@b29396-Latitude-E6410 \
--to=dongas86@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®