From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752328Ab2BOQTB (ORCPT ); Wed, 15 Feb 2012 11:19:01 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:48586 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935Ab2BOQS7 (ORCPT ); Wed, 15 Feb 2012 11:18:59 -0500 Date: Wed, 15 Feb 2012 10:18:55 -0600 From: Seth Forshee To: Akio Idehara Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix ALPS touchpad detection Message-ID: <20120215161855.GA2495@ubuntu-macmini> Mail-Followup-To: Akio Idehara , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <4F3BABF1.8050204@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F3BABF1.8050204@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2012 at 09:58:25PM +0900, Akio Idehara wrote: > ALPS touchpad detection fails if some buttons of ALPS are pressed. > The reason is that the query response byte is different from what is expected. > This was tested on a Toshiba Portege R500. I've reproduced the problem and confirmed that your approach fixes it. However, your patch seems to be malformed as it won't apply cleanly for me. For the comment you're modifying you should also keep the line length under 80 characters. This fix seems like a good candidate for stable as well. Seth