From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
stable@kernel.org
Subject: Re: [PATCH 2/2] efi: Validate UEFI boot variables
Date: Thu, 16 Feb 2012 14:27:28 +0000 [thread overview]
Message-ID: <20120216142728.64ed46e7@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1329400717-22670-2-git-send-email-mjg@redhat.com>
On Thu, 16 Feb 2012 08:58:37 -0500
Matthew Garrett <mjg@redhat.com> wrote:
> A common flaw in UEFI systems is a refusal to POST triggered by a malformed
> boot variable. Once in this state, machines may only be restored by
> reflashing their firmware with an external hardware device. While this is
> obviously a firmware bug, the serious nature of the outcome suggests that
> operating systems should filter their variable writes in order to prevent
> a malicious user from rendering the machine unusable.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
Other than pr_err() as a nitpick comemnt this looks good to me
Acked-by: Alan Cox <alan@linux.intel.com>
next prev parent reply other threads:[~2012-02-16 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 13:58 [PATCH 1/2] efi: Add new variable attributes Matthew Garrett
2012-02-16 13:58 ` [PATCH 2/2] efi: Validate UEFI boot variables Matthew Garrett
2012-02-16 14:27 ` Alan Cox [this message]
2012-04-30 20:11 [PATCH 1/2] efi: Add new variable attributes Matthew Garrett
2012-04-30 20:11 ` [PATCH 2/2] efi: Validate UEFI boot variables Matthew Garrett
2012-05-01 0:00 ` Shea Levy
2012-05-01 0:31 ` Matthew Garrett
2012-05-02 3:55 ` Ben Hutchings
2012-05-02 14:54 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216142728.64ed46e7@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=stable@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome