From: Dan Carpenter <dan.carpenter@oracle.com>
To: neilb@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: re: w1: Fix w1_bq27000
Date: Sat, 18 Feb 2012 23:51:25 +0300 [thread overview]
Message-ID: <20120218205125.GA26827@elgon.mountain> (raw)
Hello NeilBrown,
This is a semi-automatic email about new static checker warnings.
The patch 9f3519d2ed26: "w1: Fix w1_bq27000" from Feb 15, 2012, leads
to the following Smatch complaint:
drivers/w1/slaves/w1_bq27000.c:48 w1_bq27000_read()
warn: variable dereferenced before check 'dev' (see line 46)
drivers/w1/slaves/w1_bq27000.c
45 u8 val;
46 struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev);
^^^^^^^^^^^
New dereference.
47
48 if (!dev)
^^^
Old check.
49 return 0;
50
regards,
dan carpenter
next reply other threads:[~2012-02-18 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 20:51 Dan Carpenter [this message]
2012-02-19 1:48 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120218205125.GA26827@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®