From: Johann Lombardi <johann@whamcloud.com>
To: santoshprasadnayak@gmail.com
Cc: tytso@mit.edu, adilger@dilger.ca, andrew_perepechko@xyratex.com,
nikitas_angelinas@xyratex.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext4: MMP: Fix endianness bug.
Date: Thu, 23 Feb 2012 22:49:37 +0100 [thread overview]
Message-ID: <20120223214937.GC2636@granier.hd.free.fr> (raw)
In-Reply-To: <4f468ef2.4105440a.56cc.ffffa1d7@mx.google.com>
On Fri, Feb 24, 2012 at 12:39:05AM +0530, santoshprasadnayak@gmail.com wrote:
> @@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
> * If check_interval in MMP block is larger, use that instead of
> * update_interval from the superblock.
> */
> - if (mmp->mmp_check_interval > mmp_check_interval)
> - mmp_check_interval = mmp->mmp_check_interval;
> + if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
> + mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);
Looks good to me.
Reviewed-by: Johann Lombardi <johann@whamcloud.com>
Johann
next prev parent reply other threads:[~2012-02-23 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 19:09 santoshprasadnayak
2012-02-23 21:49 ` Johann Lombardi [this message]
2012-02-24 17:10 ` Andreas Dilger
2012-02-27 6:11 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223214937.GC2636@granier.hd.free.fr \
--to=johann@whamcloud.com \
--cc=adilger@dilger.ca \
--cc=andrew_perepechko@xyratex.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikitas_angelinas@xyratex.com \
--cc=santoshprasadnayak@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®