mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Devin J. Pohly" <djpohly@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] mei: cosmetic cleanup in interrupt.c
Date: Thu, 23 Feb 2012 18:51:26 -0800	[thread overview]
Message-ID: <20120224025126.GA13685@kroah.com> (raw)
In-Reply-To: <1330047536-3827-2-git-send-email-djpohly@gmail.com>

On Thu, Feb 23, 2012 at 08:38:48PM -0500, Devin J. Pohly wrote:
> From: "Devin J. Pohly" <djpohly@gmail.com>
> 
> Tabs, spaces, long lines, lines that could be combined, superfluous
> parentheses, etc.  Also uses DIV_ROUND_UP and sizeof(*ptr) where
> appropriate.

That's a lot of different things all in one patch.

Please only do one thing per patch.

Also, please cc: the maintainers of this patch, I'm sure they would also
have comments on it, use the scripts/get_maintainer.pl tool to figure
out who to send it to (hint, you also should copy the driverdevel
mailing list.)

Care to redo these please?

thanks,

greg k-h

  reply	other threads:[~2012-02-24  2:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24  1:38 Devin J. Pohly
2012-02-24  1:38 ` [PATCH 1/9] mei: cosmetic cleanup in interrupt.c Devin J. Pohly
2012-02-24  2:51   ` Greg KH [this message]
2012-02-24  1:38 ` [PATCH 2/9] mei: factor some bits of code outside if blocks Devin J. Pohly
2012-02-24  1:38 ` [PATCH 3/9] mei: more idiomatic variable/label usage Devin J. Pohly
2012-02-24  1:38 ` [PATCH 4/9] mei: return values are -Exxx, not ~Exxx! Devin J. Pohly
2012-02-27 16:35   ` Tomas Winkler
2012-02-24  1:38 ` [PATCH 5/9] mei: remove indentation where else follows return Devin J. Pohly
2012-02-24  1:38 ` [PATCH 6/9] mei: reduce indentation with early returns Devin J. Pohly
2012-02-24  1:38 ` [PATCH 7/9] mei: reduce indentation by combining if blocks Devin J. Pohly
2012-02-24  1:38 ` [PATCH 8/9] mei: reduce indentation in read_client_message Devin J. Pohly
2012-02-24  1:38 ` [PATCH 9/9] mei: reduce indentation in read_bus_message Devin J. Pohly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120224025126.GA13685@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=djpohly@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®