From: Andrew Morton <akpm@linux-foundation.org>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: <rui.zhang@intel.com>, <armando.visconti@st.com>,
<shiraz.hashim@st.com>, <vipin.kumar@st.com>,
<rajeev-dlh.kumar@st.com>, <deepak.sikri@st.com>,
<vipulkumar.samar@st.com>, <amit.virdi@st.com>,
<pratyush.anand@st.com>, <bhupesh.sharma@st.com>,
<viresh.linux@gmail.com>, <bhavna.yadav@st.com>,
<vincenzo.frascino@st.com>, <mirko.gardi@st.com>,
<salvatore.dedominicis@st.com>, <linux-kernel@vger.kernel.org>,
<len.brown@intel.com>
Subject: Re: [PATCH] thermal: Add support for thermal sensor present on SPEAr13xx machines
Date: Fri, 24 Feb 2012 12:02:51 -0800 [thread overview]
Message-ID: <20120224120251.ad8e7332.akpm@linux-foundation.org> (raw)
In-Reply-To: <032b0bad50a9ad812c9a907138bb1a6caed38c74.1330068012.git.viresh.kumar@st.com>
On Fri, 24 Feb 2012 12:57:38 +0530
Viresh Kumar <viresh.kumar@st.com> wrote:
> From: Vincenzo Frascino <vincenzo.frascino@st.com>
>
> ST's SPEAr13xx machines are based on CortexA9 ARM processors. These
> machines contain a thermal sensor for junction temperature monitoring.
>
> This patch adds support for this thermal sensor in existing thermal
> framework.
>
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -18,3 +18,10 @@ config THERMAL_HWMON
> depends on THERMAL
> depends on HWMON=y || HWMON=THERMAL
> default y
> +
> +config SPEAR_THERMAL
> + bool "SPEAr thermal sensor driver"
> + depends on THERMAL
> + help
> + Enable this to plug the SPEAr thermal sensor driver into the Linux
> + thermal framework
The driver can be compiled for all architectures which support
CONFIG_THERMAL. This includes x86_64. Was that intended?
I don't think it's necessarily a bad thing: it gives the driver a lot
more compilation coverage and exposes bugs such as
drivers/thermal/spear_thermal.c: In function 'spear_thermal_probe':
drivers/thermal/spear_thermal.c:159: warning: cast from pointer to integer of different size
--- a/drivers/thermal/spear_thermal.c~thermal-add-support-for-thermal-sensor-present-on-spear13xx-machines-fix
+++ a/drivers/thermal/spear_thermal.c
@@ -156,8 +156,8 @@ static int spear_thermal_probe(struct pl
platform_set_drvdata(pdev, spear_thermal);
- dev_info(&spear_thermal->device, "Thermal Sensor Loaded at: 0x%x.\n",
- (unsigned int)stdev->thermal_base);
+ dev_info(&spear_thermal->device, "Thermal Sensor Loaded at: 0x%p.\n",
+ stdev->thermal_base);
return 0;
but I do wonder if this was intentional.
next prev parent reply other threads:[~2012-02-24 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 7:27 Viresh Kumar
2012-02-24 20:02 ` Andrew Morton [this message]
[not found] ` <CAOh2x=kszwxhwKqwKN37Yd_KRKG5DwC_5zXXevsLpUJmJsZV0w@mail.gmail.com>
2012-02-27 22:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224120251.ad8e7332.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=amit.virdi@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=rui.zhang@intel.com \
--cc=salvatore.dedominicis@st.com \
--cc=shiraz.hashim@st.com \
--cc=vincenzo.frascino@st.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®