From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: paul.gortmaker@windriver.com, tim.bird@am.sony.com,
kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] mm: add a low limit to alloc_large_system_hash
Date: Mon, 27 Feb 2012 01:45:46 -0500 (EST) [thread overview]
Message-ID: <20120227.014546.2244934355313645351.davem@davemloft.net> (raw)
In-Reply-To: <1330322597.3330.5.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 27 Feb 2012 07:03:17 +0100
> UDP stack needs a minimum hash size value for proper operation and also
> uses alloc_large_system_hash() for proper NUMA distribution of its hash
> tables and automatic sizing depending on available system memory.
>
> On some low memory situations, udp_table_init() must ignore the
> alloc_large_system_hash() result and reallocs a bigger memory area.
>
> As we cannot easily free old hash table, we leak it and kmemleak can
> issue a warning.
>
> This patch adds a low limit parameter to alloc_large_system_hash() to
> solve this problem.
>
> We then specify UDP_HTABLE_SIZE_MIN for UDP/UDPLite hash table
> allocation.
>
> Reported-by: Mark Asselstine <mark.asselstine@windriver.com>
> Reported-by: Tim Bird <tim.bird@am.sony.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Who wants to take this?
next prev parent reply other threads:[~2012-02-27 6:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 0:55 RFC: memory leak in udp_table_init Tim Bird
2012-02-25 1:27 ` Paul Gortmaker
2012-02-25 5:19 ` Eric Dumazet
2012-02-26 19:20 ` David Miller
2012-02-27 5:40 ` Eric Dumazet
2012-02-27 5:44 ` David Miller
2012-02-27 11:33 ` David Laight
2012-02-29 18:28 ` Eric W. Biederman
2012-03-01 8:55 ` David Laight
2012-03-01 12:33 ` Eric Dumazet
2012-03-15 17:44 ` Paul E. McKenney
2012-03-02 0:12 ` Eric W. Biederman
2012-02-27 6:03 ` [PATCH v2] mm: add a low limit to alloc_large_system_hash Eric Dumazet
2012-02-27 6:45 ` David Miller [this message]
2012-05-23 23:33 Tim Bird
2012-05-24 4:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227.014546.2244934355313645351.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®