From: Ingo Molnar <mingo@elte.hu>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Anton Arapov <anton@redhat.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
Jiri Olsa <jolsa@redhat.com>, Josh Stone <jistone@redhat.com>
Subject: Re: [PATCH] uprobes/core: handle breakpoint and signal step exception.
Date: Tue, 28 Feb 2012 15:27:31 +0100 [thread overview]
Message-ID: <20120228142731.GB15700@elte.hu> (raw)
In-Reply-To: <20120228141743.GA32472@linux.vnet.ibm.com>
* Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:
> > > The current unregistering thread waits till all other
> > > threads that have hit a breakpoint to acquire the
> > > uprobes_treelock before the uprobe is removed from the
> > > rbtree.
> >
> > s/is removed/are removed
> >
> > ?
> >
>
> At a time, we are unregistering just one probe,(atleast for
> now.) Wondering if "before uprobes are remove from rbtree."
> sounds as if more than one uprobe is being removed at one
> instance.
The sentence still does not parse:
" X waits until Ys that have done Z before A is removed from
the rbtree"
Did you want to say:
" The current unregistering thread waits till all other
threads have hit a breakpoint, to acquire the
uprobes_treelock before the uprobe is removed from the
rbtree. "
(I have removed 'that' and added a comma.)
Thanks,
Ingo
next prev parent reply other threads:[~2012-02-28 14:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 11:02 Srikar Dronamraju
2012-02-23 12:18 ` Anton Arapov
2012-02-24 5:31 ` Srikar Dronamraju
2012-02-27 9:12 ` Ingo Molnar
2012-02-28 13:26 ` Srikar Dronamraju
2012-02-28 13:52 ` Ingo Molnar
2012-02-28 14:17 ` Srikar Dronamraju
2012-02-28 14:27 ` Ingo Molnar [this message]
2012-03-08 13:18 ` Srikar Dronamraju
2012-03-08 13:48 ` Ingo Molnar
2012-03-09 6:28 ` Srikar Dronamraju
2012-03-09 7:33 ` Ingo Molnar
2012-03-13 5:20 ` Ingo Molnar
2012-03-13 5:42 ` Ingo Molnar
2012-03-13 5:47 ` Ingo Molnar
2012-03-13 9:24 ` Srikar Dronamraju
2012-03-13 9:38 ` Ingo Molnar
2012-02-27 9:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228142731.GB15700@elte.hu \
--to=mingo@elte.hu \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jistone@redhat.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®