From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, <linux-kernel@vger.kernel.org>,
<kvm@vger.kernel.org>, <joro@8bytes.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>,
Stephane Eranian <eranian@google.com>,
Gleb Natapov <gleb@redhat.com>,
Robert Richter <robert.richter@amd.com>
Subject: Re: [PATCH] perf/x86: Fix HO/GO counting with SVM disabled
Date: Wed, 29 Feb 2012 14:24:10 +0100 [thread overview]
Message-ID: <20120229132410.GB10684@amd.com> (raw)
In-Reply-To: <4F4D111A.8020001@redhat.com>
On Tue, Feb 28, 2012 at 07:38:34PM +0200, Avi Kivity wrote:
> On 02/28/2012 07:36 PM, David Ahern wrote:
> > I was to suggest the reverse: since this patch addesses an AMD bug,
> > why not push those functions into perf_event_amd.c and make them
> > dependent on CONFIG_CPU_SUP_AMD as well.
>
> It depends on which direction you expect the code to grow. These hooks
> seem reasonable, so I think they should be generic.
Okay, I am fine with both directions. But since this patch is a fix in
the first place I make it more AMD specific for now. If we need this as
a generic feature it can easily be changed back.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-02-29 13:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 17:33 [PATCH] perf tools: fix guest mode monitoring on AMD Stephane Eranian
2012-02-27 17:39 ` Gleb Natapov
2012-02-27 17:47 ` David Ahern
2012-02-27 17:52 ` Stephane Eranian
2012-02-27 18:00 ` David Ahern
2012-02-27 18:23 ` Joerg Roedel
2012-02-28 15:55 ` [PATCH] perf/x86: Fix HO/GO counting with SVM disabled Joerg Roedel
2012-02-28 17:24 ` Avi Kivity
2012-02-28 17:36 ` David Ahern
2012-02-28 17:38 ` Avi Kivity
2012-02-29 13:24 ` Joerg Roedel [this message]
2012-02-29 13:57 ` [PATCH v2] " Joerg Roedel
2012-02-29 17:00 ` Avi Kivity
2012-02-29 17:03 ` Gleb Natapov
2012-02-29 17:05 ` Joerg Roedel
2012-02-29 17:08 ` Avi Kivity
2012-02-29 17:24 ` Peter Zijlstra
2012-02-29 17:44 ` Peter Zijlstra
2012-03-02 14:54 ` [tip:perf/urgent] perf/x86/kvm: Fix Host-Only/ Guest-Only " tip-bot for Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229132410.GB10684@amd.com \
--to=joerg.roedel@amd.com \
--cc=a.p.zijlstra@chello.nl \
--cc=avi@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=gleb@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome