mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eric Andersson <eric.andersson@unixphere.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, christoph.mair@gmail.com,
	stefan.nilsson@unixphere.com, zhengguang.guo@bosch-sensortec.com,
	peter.moeller@cn.bosch.com
Subject: Re: [PATCH 1/3] drivers/misc: add support for BMP18x pressure sensors
Date: Thu, 1 Mar 2012 00:11:43 +0000	[thread overview]
Message-ID: <20120301001143.02f6c8c4@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1330545489-31169-2-git-send-email-eric.andersson@unixphere.com>

On Wed, 29 Feb 2012 20:58:07 +0100
Eric Andersson <eric.andersson@unixphere.com> wrote:

> This driver adds support for Bosch Sensortec's pressure sensors
> BMP085 and BMP18x.
> 
> The driver is based on the bmp085 driver by Christoph Mair
> and uses the same sysfs interface.

This is really extending bmp085 to cover the 18x chips. We don't normally
rename everything for that, and you risk breaking existing setups
assuming the module name is bmp085.

So please just "update" the existing driver - ie the code looks fine but
it should still end up being bmp085.

Alan

  reply	other threads:[~2012-03-01  0:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 19:58 [PATCH 0/3] Replace bmp085 with bmp18x Eric Andersson
2012-02-29 19:58 ` [PATCH 1/3] drivers/misc: add support for BMP18x pressure sensors Eric Andersson
2012-03-01  0:11   ` Alan Cox [this message]
2012-02-29 19:58 ` [PATCH 2/3] Documentation: add sysfs ABI documentation for bmp18x Eric Andersson
2012-02-29 19:58 ` [PATCH 3/3] drivers/misc: remove bmp085 driver Eric Andersson
2012-02-29 20:18 ` [PATCH 0/3] Replace bmp085 with bmp18x Arnd Bergmann
2012-02-29 20:37   ` Nick Bowler
2012-02-29 21:26     ` Arnd Bergmann
2012-03-01 13:19       ` Eric Andersson
2012-02-29 21:19   ` Eric Andersson
2012-02-29 23:52   ` Alan Cox
2012-03-02 16:49     ` Arnd Bergmann
2012-03-02 17:04       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120301001143.02f6c8c4@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=arnd@arndb.de \
    --cc=christoph.mair@gmail.com \
    --cc=eric.andersson@unixphere.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.moeller@cn.bosch.com \
    --cc=stefan.nilsson@unixphere.com \
    --cc=zhengguang.guo@bosch-sensortec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®