From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030818Ab2CAMak (ORCPT ); Thu, 1 Mar 2012 07:30:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38223 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759093Ab2CAMah (ORCPT ); Thu, 1 Mar 2012 07:30:37 -0500 Date: Thu, 1 Mar 2012 13:30:35 +0100 From: Jan Kara To: Jeff Layton Cc: Jan Kara , Andrew Morton , linux-mm@kvack.org, LKML , Al Viro , linux-fsdevel@vger.kernel.org, dchinner@redhat.com, Steve French , linux-cifs@vger.kernel.org Subject: Re: [PATCH 4/9] cifs: Push file_update_time() into cifs_page_mkwrite() Message-ID: <20120301123035.GF4385@quack.suse.cz> References: <1330602103-8851-1-git-send-email-jack@suse.cz> <1330602103-8851-5-git-send-email-jack@suse.cz> <20120301072537.502bd918@tlielax.poochiereds.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120301072537.502bd918@tlielax.poochiereds.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 01-03-12 07:25:37, Jeff Layton wrote: > On Thu, 1 Mar 2012 12:41:38 +0100 > Jan Kara wrote: > > > CC: Steve French > > CC: linux-cifs@vger.kernel.org > > Signed-off-by: Jan Kara > > --- > > fs/cifs/file.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/fs/cifs/file.c b/fs/cifs/file.c > > index 4dd9283..8e3b23b 100644 > > --- a/fs/cifs/file.c > > +++ b/fs/cifs/file.c > > @@ -2425,6 +2425,9 @@ cifs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > > { > > struct page *page = vmf->page; > > > > + /* Update file times before taking page lock */ > > + file_update_time(vma->vm_file); > > + > > lock_page(page); > > return VM_FAULT_LOCKED; > > } > > Sorry, I meant to comment on this earlier... > > I think we can probably drop this patch. cifs doesn't currently set > S_NOCMTIME on all inodes (only when MS_NOATIME is set currently), but I > think that it probably should. Timestamps should be the purview of the > server. OK, thanks for letting me know. Patch dropped. Honza -- Jan Kara SUSE Labs, CR