From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Alan Cox <alan@linux.intel.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH 1/4] x86: add NO_IRQ macro
Date: Thu, 1 Mar 2012 14:07:53 +0000 [thread overview]
Message-ID: <20120301140753.5c44e27e@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <6bda7538144dce0bf5780df3d0601147dae753b5.1330607068.git.rubini@gnudd.com>
On Thu, 1 Mar 2012 14:28:36 +0100
Alessandro Rubini <rubini@gnudd.com> wrote:
> This is needed to compile AMBA drivers. Most architectures define
> NO_IRQ as -1, and this does the same for the PC.
NAK
"No IRQ" is 0. There are a few platforms which incorrectly still define it
as -1 but they are broken and in fact many drivers won't work with
platforms that still incorrectly use -1. Nothing should be using a
NO_IRQ define.
Fix the users.
Alan
next prev parent reply other threads:[~2012-03-01 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 13:28 [PATCH 0/4] Initial steps to compile AMBA for x86 Alessandro Rubini
2012-03-01 13:28 ` [PATCH 1/4] x86: add NO_IRQ macro Alessandro Rubini
2012-03-01 13:30 ` Russell King - ARM Linux
2012-03-01 14:07 ` Alan Cox [this message]
2012-03-01 14:11 ` Russell King - ARM Linux
2012-03-01 13:28 ` [PATCH 2/4] sizes.h: move from asm-generic to <linux/sizes.h> Alessandro Rubini
2012-03-01 13:55 ` Arnd Bergmann
2012-03-01 13:28 ` [PATCH 3/4] amba: use the new linux/sizes.h Alessandro Rubini
2012-03-01 13:29 ` [PATCH 4/4] ARM: " Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301140753.5c44e27e@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome