From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754697Ab2CDSfz (ORCPT ); Sun, 4 Mar 2012 13:35:55 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:60611 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754669Ab2CDSfR (ORCPT ); Sun, 4 Mar 2012 13:35:17 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of olof@lixom.net designates 10.68.72.9 as permitted sender) smtp.mail=olof@lixom.net Date: Sun, 4 Mar 2012 10:35:13 -0800 From: Olof Johansson To: Alan Ott Cc: Colin Cross , Stephen Warren , Russell King , Lucas De Marchi , Arnd Bergmann , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] ARM: tegra: do not hide dma declarations Message-ID: <20120304183513.GA31064@quad.lixom.net> References: <1330721903-8571-1-git-send-email-alan@signal11.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330721903-8571-1-git-send-email-alan@signal11.us> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 02, 2012 at 03:58:23PM -0500, Alan Ott wrote: > From: Arnd Bergmann > > The declarations are actually required for the device > definitions, and are still valid even if the dma controller > is disabled: > > arch/arm/mach-tegra/devices.c:559:12: error: 'TEGRA_DMA_REQ_SEL_I2S_1' undeclared here (not in a function) > arch/arm/mach-tegra/devices.c:577:12: error: 'TEGRA_DMA_REQ_SEL_I2S2_1' undeclared here (not in a function) > > Signed-off-by: Arnd Bergmann > Signed-off-by: Alan Ott Thanks, applied to cleanups-and-fixes for 3.4. -Olof