From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, stable@vger.kernel.org,
lwn@lwn.net, Tony Luck <tony.luck@intel.com>,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: Build broken on s390 and ia64 [was: Linux 2.6.32.58]
Date: Mon, 5 Mar 2012 13:02:41 +0100 [thread overview]
Message-ID: <20120305120241.GA3627@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <4F54A46A.6000305@suse.cz>
On Mon, Mar 05, 2012 at 12:32:58PM +0100, Jiri Slaby wrote:
> On 03/04/2012 07:09 PM, Greg KH wrote:
> > I'm announcing the release of the 2.6.32.58 kernel.
> ...
> > Heiko Carstens (1): compat: fix compile breakage on s390
>
> It's not that minimal it suggests. It removed asm/compat.h inclusion
> from arch/s390/kernel/setup.c. This causes build failures on
> !CONFIG_COMPAT:
> arch/s390/kernel/setup.c: In function 'setup_addressing_mode':
> arch/s390/kernel/setup.c:382: error: 'PSW32_ASC_SECONDARY' undeclared
> (first use in this function)
> arch/s390/kernel/setup.c:382: error: (Each undeclared identifier is
> reported only once
> arch/s390/kernel/setup.c:382: error: for each function it appears in.)
> arch/s390/kernel/setup.c:389: error: 'PSW32_ASC_PRIMARY' undeclared
> (first use in this function)
Ah, right. For kernels < 3.0 it is indeed necessary to include
asm/compat.h in arch/s390/kernel/setup.c.
The need for that got eliminated with
043d07084b5347a26eab0a07aa13a4a929ad9e71 "[S390] Remove data execution
protection".
> Perhaps asm/compat.h should be included from linux/compat.h
> unconditionally...
If you do that you need to add #ifdef wrappers around the is_compat_task()
definitions in each arch that supports CONFIG_COMPAT. If that's all that's
needed that would be great!
> > Linus Torvalds (2): Fix autofs compile without CONFIG_COMPAT
>
> But who defines is_compat_task *with* CONFIG_COMPAT on ia64?
>
> fs/autofs4/inode.c: In function 'autofs4_fill_super':
> fs/autofs4/inode.c:345: error: implicit declaration of function
> 'is_compat_task'
The ia64 compat code got entirely removed, since it was broken:
32974ad4907cdde6c9de612cd1b2ee0568fb9409 "[IA64] Remove COMPAT_IA32 support"
next prev parent reply other threads:[~2012-03-05 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 18:09 Linux 2.6.32.58 Greg KH
2012-03-04 18:09 ` Greg KH
2012-03-04 23:22 ` Willy Tarreau
2012-03-05 11:32 ` Build broken on s390 and ia64 [was: Linux 2.6.32.58] Jiri Slaby
2012-03-05 12:02 ` Heiko Carstens [this message]
2012-03-05 12:48 ` Jiri Slaby
2012-03-05 12:54 ` Willy Tarreau
2012-03-05 12:56 ` Jiri Slaby
2012-03-05 13:13 ` Heiko Carstens
2012-03-05 13:18 ` Willy Tarreau
2012-03-05 22:33 ` Willy Tarreau
2012-03-08 11:06 ` Jiri Slaby
2012-03-08 11:47 ` Willy Tarreau
2012-03-09 5:29 ` Ben Hutchings
2012-03-09 6:57 ` Willy Tarreau
2012-03-09 8:23 ` Jiri Slaby
2012-03-09 8:41 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305120241.GA3627@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®