From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, ctalbott@google.com, rni@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET] blkcg: accumulated blkcg updates
Date: Tue, 6 Mar 2012 10:07:09 -0500 [thread overview]
Message-ID: <20120306150709.GA32148@redhat.com> (raw)
In-Reply-To: <20120305210836.GD1263@google.com>
On Mon, Mar 05, 2012 at 01:08:36PM -0800, Tejun Heo wrote:
> On Mon, Mar 05, 2012 at 01:07:26PM -0800, Tejun Heo wrote:
> > Hello,
> >
> > Vivek reported two different crashes. Patch 17.5 added and patch 27
> > updated to address both issues. Andrew reminded me a deeper problem
> > with percpu mempool approach and I'll go with Vivek's delayed
> > allocation patch. For now, I'm dropping the stats patches.
> >
> > I posted the two updated patches but holding off reposting all patches
> > which now generate conflicts due to the updates. git branches are
> > updated.
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git blkcg-stacking
> > git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git unified-blkg
> > git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git blkcg-kill-pn
> >
> > Note that blkcg-stats is dropped for now. I'll repost the series
> > later when Jens is ready to pull.
>
> Ooh, the commit ID of blkcg-stacking, which is on top of all other
> pending commits is fcddfec4ea9067ae6c963682dcdb5ddf783a3ff9.
>
> Vivek, can you please verify the crashes you were seeing are gone now?
Hi Tejun,
Built and booted into blkcg-stacking. Looks likd old crashes on reading
file and scheduler change are fixed.
My system is hanging during reboot. Last message I see is "Detaching DM
devices" and nothing happens after that. I shall have to do some more
testing to figure out when did that start happening.
I have been seeing following on boot though.
[ 2.893244] ===============================
[ 2.897492] [ INFO: suspicious RCU usage. ]
[ 2.901741] 3.3.0-rc3-tejun-misc+ #27 Not tainted
[ 2.906509] -------------------------------
[ 2.910760] kernel/cgroup.c:1723 suspicious rcu_dereference_check()
usage!
[ 2.917696]
[ 2.917697] other info that might help us debug this:
[ 2.917698]
[ 2.925919]
[ 2.925920] rcu_scheduler_active = 1, debug_locks = 0
[ 2.932588] no locks held by swapper/0/1.
[ 2.936664]
[ 2.936664] stack backtrace:
[ 2.941180] Pid: 1, comm: swapper/0 Not tainted 3.3.0-rc3-tejun-misc+
#27
[ 2.948030] Call Trace:
[ 2.950550] [<ffffffff81093ba5>] lockdep_rcu_suspicious+0xe5/0x100
[ 2.956883] [<ffffffff810adfbe>] cgroup_path+0x1be/0x200
[ 2.962350] [<ffffffff8130af55>] blkg_lookup_create+0x1d5/0x490
[ 2.968422] [<ffffffff8130d3b5>] blk_throtl_init+0x135/0x220
[ 2.974237] [<ffffffff8130d369>] ? blk_throtl_init+0xe9/0x220
[ 2.980141] [<ffffffff8130b6e1>] blkcg_init_queue+0x31/0x90
[ 2.985874] [<ffffffff812f2c2a>] blk_alloc_queue_node+0x22a/0x270
[ 2.992120] [<ffffffff812f2c83>] blk_alloc_queue+0x13/0x20
[ 2.997761] [<ffffffff81447cba>] brd_alloc+0x7a/0x1b0
[ 3.002968] [<ffffffff81f0163e>] brd_init+0xc6/0x1ce
[ 3.008086] [<ffffffff81f01578>] ? register_node_type+0x19/0x19
[ 3.014167] [<ffffffff810001cf>] do_one_initcall+0x3f/0x170
[ 3.019893] [<ffffffff81ed4c34>] kernel_init+0xc9/0x143
[ 3.025273] [<ffffffff81844e24>] kernel_thread_helper+0x4/0x10
[ 3.031258] [<ffffffff8183b65d>] ? retint_restore_args+0xe/0xe
[ 3.037244] [<ffffffff81ed4b6b>] ? start_kernel+0x375/0x375
[ 3.042968] [<ffffffff81844e20>] ? gs_change+0xb/0xb
Thanks
Vivek
next prev parent reply other threads:[~2012-03-06 15:07 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 1:46 Tejun Heo
2012-02-22 1:46 ` [PATCH 01/36] block: blk-throttle should be drained regardless of q->elevator Tejun Heo
2012-02-22 1:46 ` [PATCH 02/36] blkcg: make CONFIG_BLK_CGROUP bool Tejun Heo
2012-02-22 1:46 ` [PATCH 03/36] cfq: don't register propio policy if !CONFIG_CFQ_GROUP_IOSCHED Tejun Heo
2012-02-22 1:46 ` [PATCH 04/36] elevator: clear auxiliary data earlier during elevator switch Tejun Heo
2012-02-22 1:46 ` [PATCH 05/36] elevator: make elevator_init_fn() return 0/-errno Tejun Heo
2012-02-22 1:46 ` [PATCH 06/36] block: implement blk_queue_bypass_start/end() Tejun Heo
2012-02-22 1:46 ` [PATCH 07/36] block: extend queue bypassing to cover blkcg policies Tejun Heo
2012-02-22 1:46 ` [PATCH 08/36] blkcg: shoot down blkio_groups on elevator switch Tejun Heo
2012-02-22 1:46 ` [PATCH 09/36] blkcg: move rcu_read_lock() outside of blkio_group get functions Tejun Heo
2012-02-22 1:46 ` [PATCH 10/36] blkcg: update blkg get functions take blkio_cgroup as parameter Tejun Heo
2012-02-22 1:46 ` [PATCH 11/36] blkcg: use q and plid instead of opaque void * for blkio_group association Tejun Heo
2012-02-22 1:46 ` [PATCH 12/36] blkcg: add blkio_policy[] array and allow one policy per policy ID Tejun Heo
2012-02-22 1:46 ` [PATCH 13/36] blkcg: use the usual get blkg path for root blkio_group Tejun Heo
2012-02-22 1:46 ` [PATCH 14/36] blkcg: factor out blkio_group creation Tejun Heo
2012-02-22 1:46 ` [PATCH 15/36] blkcg: don't allow or retain configuration of missing devices Tejun Heo
2012-02-22 1:46 ` [PATCH 16/36] blkcg: kill blkio_policy_node Tejun Heo
2012-02-22 1:46 ` [PATCH 17/36] blkcg: kill the mind-bending blkg->dev Tejun Heo
2012-02-22 1:46 ` [PATCH 18/36] blkcg: let blkio_group point to blkio_cgroup directly Tejun Heo
2012-02-22 1:46 ` [PATCH 19/36] blkcg: add blkcg_{init|drain|exit}_queue() Tejun Heo
2012-02-22 1:46 ` [PATCH 20/36] blkcg: clear all request_queues on blkcg policy [un]registrations Tejun Heo
2012-02-22 1:46 ` [PATCH 21/36] blkcg: let blkcg core handle policy private data allocation Tejun Heo
2012-02-22 1:46 ` [PATCH 22/36] blkcg: move refcnt to blkcg core Tejun Heo
2012-02-22 1:46 ` [PATCH 23/36] blkcg: make blkg->pd an array and move configuration and stats into it Tejun Heo
2012-02-22 1:46 ` [PATCH 24/36] blkcg: don't use blkg->plid in stat related functions Tejun Heo
2012-02-22 1:46 ` [PATCH 25/36] blkcg: move per-queue blkg list heads and counters to queue and blkg Tejun Heo
2012-02-22 1:46 ` [PATCH 26/36] blkcg: let blkcg core manage per-queue blkg list and counter Tejun Heo
2012-02-22 1:46 ` [PATCH 27/36] blkcg: unify blkg's for blkcg policies Tejun Heo
2012-03-05 21:01 ` [PATCH UPDATED " Tejun Heo
2012-02-22 1:46 ` [PATCH 28/36] blkcg: use double locking instead of RCU for blkg synchronization Tejun Heo
2012-02-22 1:46 ` [PATCH 29/36] blkcg: drop unnecessary RCU locking Tejun Heo
2012-02-23 18:51 ` [PATCH UPDATED " Tejun Heo
2012-02-22 1:46 ` [PATCH 30/36] block: restructure get_request() Tejun Heo
2012-02-22 1:46 ` [PATCH 31/36] block: interface update for ioc/icq creation functions Tejun Heo
2012-02-22 1:46 ` [PATCH 32/36] block: ioc_task_link() can't fail Tejun Heo
2012-02-22 1:47 ` [PATCH 33/36] block: add io_context->active_ref Tejun Heo
2012-02-22 18:47 ` Vivek Goyal
2012-02-22 19:13 ` Tejun Heo
2012-02-23 18:20 ` Vivek Goyal
2012-02-22 1:47 ` [PATCH 34/36] block: implement bio_associate_current() Tejun Heo
2012-02-22 13:45 ` Jeff Moyer
2012-02-22 19:07 ` Tejun Heo
2012-02-22 19:33 ` Jeff Moyer
2012-02-22 19:37 ` Vivek Goyal
2012-02-22 19:41 ` Jeff Moyer
2012-02-22 1:47 ` [PATCH 35/36] block: make block cgroup policies follow bio task association Tejun Heo
2012-02-22 1:47 ` [PATCH 36/36] block: make blk-throttle preserve the issuing task on delayed bios Tejun Heo
2012-02-22 19:34 ` [PATCHSET] blkcg: accumulated blkcg updates Vivek Goyal
2012-02-22 22:04 ` Tejun Heo
2012-03-05 20:59 ` [PATCH 17.5] blkcg: skip blkg printing if q isn't associated with disk Tejun Heo
2012-03-05 21:07 ` [PATCHSET] blkcg: accumulated blkcg updates Tejun Heo
2012-03-05 21:08 ` Tejun Heo
2012-03-06 15:07 ` Vivek Goyal [this message]
2012-03-06 16:24 ` Vivek Goyal
2012-03-06 18:39 ` Vivek Goyal
2012-03-06 19:02 ` Vivek Goyal
2012-03-08 0:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306150709.GA32148@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rni@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome