mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Copot Alexandru <alex.mihai.c@gmail.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] mm: fix spelling error
Date: Tue, 6 Mar 2012 16:31:10 -0800	[thread overview]
Message-ID: <20120306163110.56f67676.akpm@linux-foundation.org> (raw)
In-Reply-To: <1330783996-7955-1-git-send-email-alex.mihai.c@gmail.com>

On Sat,  3 Mar 2012 16:13:16 +0200
Copot Alexandru <alex.mihai.c@gmail.com> wrote:

> Signed-off-by: Copot Alexandru <alex.mihai.c@gmail.com>
> ---
>  mm/vmscan.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index c52b235..8a7c989 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2250,13 +2250,13 @@ static bool shrink_zones(int priority, struct zonelist *zonelist,
>  				continue;	/* Let kswapd poll it */
>  			if (COMPACTION_BUILD) {
>  				/*
> -				 * If we already have plenty of memory free for
> -				 * compaction in this zone, don't free any more.
> -				 * Even though compaction is invoked for any
> -				 * non-zero order, only frequent costly order
> -				 * reclamation is disruptive enough to become a
> -				 * noticable problem, like transparent huge page
> -				 * allocations.
> +				 * If we already have plenty of memory free
> +				 * for compaction in this zone, don't free any
> +				 * more.  Even though compaction is invoked
> +				 * for any non-zero order, only frequent
> +				 * costly order reclamation is disruptive
> +				 * enough to become a noticeable problem, like
> +				 * transparent huge page allocations.
>  				 */
>  				if (compaction_ready(zone, sc)) {
>  					aborted_reclaim = true;

hm, you appear to have reformatted the comment to fit into 78 column or
something.  We have 80 to use!

AFACIT the sole spelling mistake was s/noticable/noticeable/.

More significantly, the comment is hard to follow.  Perhaps removing
the "only" wold fix it up.



  reply	other threads:[~2012-03-07  0:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-03 14:13 Copot Alexandru
2012-03-07  0:31 ` Andrew Morton [this message]
2017-04-03 16:16 Hao Lee
2017-05-10  2:38 ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120306163110.56f67676.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alex.mihai.c@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome