From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752922Ab2CHKpU (ORCPT ); Thu, 8 Mar 2012 05:45:20 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:59728 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029Ab2CHKpN (ORCPT ); Thu, 8 Mar 2012 05:45:13 -0500 Date: Thu, 8 Mar 2012 11:44:32 +0100 From: Ingo Molnar To: Namhyung Kim Cc: Namhyung Kim , Arun Sharma , Arnaldo Carvalho de Melo , Peter Zijlstra , Stephane Eranian , linux-kernel@vger.kernel.org, dsahern@gmail.com, ravitillo@lbl.gov, khandual@linux.vnet.ibm.com, robert.richter@amd.com, ming.m.lin@intel.com, vweaver1@eecs.utk.edu, andi@firstfloor.org Subject: Re: [RFC] perf report: Implement symbol filtering on TUI Message-ID: <20120308104432.GB25949@elte.hu> References: <20120306062546.GA622@elte.hu> <1331085470-32594-1-git-send-email-namhyung.kim@lge.com> <20120307060724.GA4241@elte.hu> <4F5716A2.6070804@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F5716A2.6070804@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=AWL,BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 AWL AWL: From: address is in the auto white-list Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Namhyung Kim wrote: > Hi, Ingo > > 2012-03-07 3:07 PM, Ingo Molnar wrote: > > > >* Namhyung Kim wrote: > > > >>As Ingo requested, symbol filtering feature was missing on TUI. > >>Add 's' key to get input from user, and do simple filtering by > >>strstr(). To turn filtering off, just enter no name by pressing > >>'s' followed by ENTER. > >> > >>There should be many issues, but I just want to release this > >>to get some feedbacks. > > > >I'd love it if in addition to the hotkey, if I typed the obvious > >sequence: > > > > $ perf report sched > > > >... then it would turn into such a filter automagically. > > > > Oh, I implemented that already. Please test it! :) Cool - I tried it out and it works just as it should! I noticed two details: - "perf report sched | less" does not work as expected - such kinds of features should be GUI-frontend agnostic. - unknown symbols are not matched, and thus they will show up indiscrimnately even though I only want to see them if the filter is something like '0x' or 'unknown'. Anyway, apart from these two details: Tested-by: Ingo Molnar Thanks, Ingo