From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756172Ab2CHSEl (ORCPT ); Thu, 8 Mar 2012 13:04:41 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:51927 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755757Ab2CHSEg (ORCPT ); Thu, 8 Mar 2012 13:04:36 -0500 Subject: [PATCH v5 7/7] mm/memcg: use vm_swappiness from target memory cgroup To: Andrew Morton , Hugh Dickins , Johannes Weiner , KAMEZAWA Hiroyuki From: Konstantin Khlebnikov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Thu, 08 Mar 2012 22:04:30 +0400 Message-ID: <20120308180430.27621.99232.stgit@zurg> In-Reply-To: <20120308175752.27621.54781.stgit@zurg> References: <20120308175752.27621.54781.stgit@zurg> User-Agent: StGit/0.15 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use vm_swappiness from memory cgroup which is triggered this memory reclaim. This is more reasonable and allows to kill one argument. Signed-off-by: Konstantin Khlebnikov --- add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-2 (-2) function old new delta shrink_mem_cgroup_zone 1583 1581 -2 --- mm/vmscan.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 9a41769..95719f3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1859,12 +1859,11 @@ static unsigned long shrink_list(enum lru_list lru, unsigned long nr_to_scan, return shrink_inactive_list(nr_to_scan, mz, sc, priority, lru); } -static int vmscan_swappiness(struct mem_cgroup_zone *mz, - struct scan_control *sc) +static int vmscan_swappiness(struct scan_control *sc) { if (global_reclaim(sc)) return vm_swappiness; - return mem_cgroup_swappiness(mz->mem_cgroup); + return mem_cgroup_swappiness(sc->target_mem_cgroup); } /* @@ -1933,8 +1932,8 @@ static void get_scan_count(struct mem_cgroup_zone *mz, struct scan_control *sc, * With swappiness at 100, anonymous and file have the same priority. * This scanning priority is essentially the inverse of IO cost. */ - anon_prio = vmscan_swappiness(mz, sc); - file_prio = 200 - vmscan_swappiness(mz, sc); + anon_prio = vmscan_swappiness(sc); + file_prio = 200 - vmscan_swappiness(sc); /* * OK, so we have swap space and a fair amount of page cache