mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@hack.frob.com>
To: Jason Baron <jbaron@redhat.com>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
	avi@redhat.com, cmetcalf@tilera.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] core dump: add VM_NODUMP, MADV_NODUMP, MADV_CLEAR_NODUMP
Date: Thu,  8 Mar 2012 13:44:17 -0800 (PST)	[thread overview]
Message-ID: <20120308214417.328502C0C8@topped-with-meat.com> (raw)
In-Reply-To: Jason Baron's message of  Thursday, 8 March 2012 16:29:30 -0500 <f52c6c288ec291c8cdc6176673d5b0d3d33a6f14.1331238525.git.jbaron@redhat.com>

I'm vaguely dubious about the desireability of using this new feature.
(I would hate to try to debug a qemu bug from a dump where half the
interesting state was intentionally hidden from me.)  But I don't see
any problem with the implementation.

As to the interface, I think the bits are OK but it would be more
in keeping with the existing MADV_* names to call the new values
MADV_DONTDUMP and MADV_DODUMP.


Thanks,
Roland

  reply	other threads:[~2012-03-08 21:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 21:29 [PATCH 0/2 v2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_NODUMP Jason Baron
2012-03-08 21:29 ` [PATCH 1/2 v2] core dump: drop VM_ALWAYSDUMP flag Jason Baron
2012-03-08 21:38   ` Roland McGrath
2012-03-08 21:29 ` [PATCH 2/2 v2] core dump: add VM_NODUMP, MADV_NODUMP, MADV_CLEAR_NODUMP Jason Baron
2012-03-08 21:44   ` Roland McGrath [this message]
2012-03-08 23:05     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120308214417.328502C0C8@topped-with-meat.com \
    --to=roland@hack.frob.com \
    --cc=akpm@linux-foundation.org \
    --cc=avi@redhat.com \
    --cc=cmetcalf@tilera.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®