mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
	patches@linaro.org, Nancy Chen <Nancy.Chen@freescale.com>,
	Liam Girdwood <lrg@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
	Axel Lin <axel.lin@gmail.com>
Subject: Re: [PATCH v10] Regulator: Add Anatop regulator driver
Date: Fri, 9 Mar 2012 12:31:30 +0000	[thread overview]
Message-ID: <20120309123130.GO3273@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120309095834.GM27213@game.jcrosoft.org>

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

On Fri, Mar 09, 2012 at 10:58:34AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:

> > I've modify the patch based on your review. However, the last one cannot
> > be made because regulator_unregister is void return.

> so we have a issue here regulator_unregister MUST return an error conde

The error handling on remove is totally irrelevant to merging this
driver.  If you want to work on changing this in the core you're more
than welcome to spend your time on it, I'm really not sure it's really
worth the time or effort for the systems we currently have, if someone
actually has a system where it becomes relevant then they can work on
it.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-03-09 12:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  9:59 Ying-Chun Liu (PaulLiu)
2012-03-08 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09  8:00   ` Ying-Chun Liu (PaulLiu)
2012-03-09  9:58     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09 12:31       ` Mark Brown [this message]
2012-03-09  2:59 ` Axel Lin
2012-03-09  3:45 ` Axel Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120309123130.GO3273@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=Nancy.Chen@freescale.com \
    --cc=axel.lin@gmail.com \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=patches@linaro.org \
    --cc=paul.liu@linaro.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®