From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: Fix missing prototype of devres_alloc() and friends
Date: Fri, 9 Mar 2012 15:30:00 -0500 [thread overview]
Message-ID: <20120309203000.GA10835@windriver.com> (raw)
In-Reply-To: <1331324248-1599-1-git-send-email-swarren@wwwdotorg.org>
[[PATCH] regmap: Fix missing prototype of devres_alloc() and friends] On 09/03/2012 (Fri 13:17) Stephen Warren wrote:
> regmap.s uses devres_alloc() and others that are prototyped in device.h.
> Include that to solve the following:
Thanks, I've already taken care of this earlier today.
http://marc.info/?l=linux-next&m=133130596327850&w=2
Paul.
>
> drivers/base/regmap/regmap.c: In function 'devm_regmap_init':
> drivers/base/regmap/regmap.c:331:2: error: implicit declaration of function 'devres_alloc' [-Werror=implicit-function-declaration]
> drivers/base/regmap/regmap.c:338:3: error: implicit declaration of function 'devres_add' [-Werror=implicit-function-declaration]
> drivers/base/regmap/regmap.c:340:3: error: implicit declaration of function 'devres_free' [-Werror=implicit-function-declaration]
> drivers/base/regmap/regmap.c: In function '_regmap_raw_write':
> drivers/base/regmap/regmap.c:421:5: error: implicit declaration of function 'dev_err' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
> drivers/base/regmap/regmap.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index e1a4097..7a3f535 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -10,6 +10,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/device.h>
> #include <linux/slab.h>
> #include <linux/export.h>
> #include <linux/mutex.h>
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2012-03-09 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 20:17 Stephen Warren
2012-03-09 20:30 ` Paul Gortmaker [this message]
2012-03-11 12:49 ` Mark Brown
2012-03-11 12:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309203000.GA10835@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome