From: Dave Young <dyoung@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux@arm.linux.org.uk, vgoyal@redhat.com
Subject: [PATCH v2] kdump x86: fix total mem size calculation for reservation
Date: Sat, 10 Mar 2012 12:56:33 +0800 [thread overview]
Message-ID: <20120310045632.GA4214@darkstar.redhat.com> (raw)
In-Reply-To: <4F5ACA2D.5000000@gmail.com>
crashkernel reservation need know the total memory size. Current get_total_mem
simply use max_pfn - min_low_pfn. It is wrong because it will including
memory holes in the middle.
Especially for kvm guest with memory > 0xe0000000, there's below in qemu code:
qemu split memory as below:
if (ram_size >= 0xe0000000 ) {
above_4g_mem_size = ram_size - 0xe0000000;
below_4g_mem_size = 0xe0000000;
} else {
below_4g_mem_size = ram_size;
}
So for 4G mem guest, seabios will insert a 512M usable region beyond of 4G.
Thus in above case max_pfn - min_low_pfn will be more than original memsize.
Fixing this issue by using memblock_phys_mem_size() to get the total memsize.
[v1 -> v2]: refresh the patch based on latest linus tree
Signed-off-by: Dave Young <dyoung@redhat.com>
---
[Ther's similar code in arm, I'm not sure whether the memblock_phys_mem_size
works with arm or not. If it works I can also update that part of code.]
arch/x86/kernel/setup.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
--- linux-2.6.orig/arch/x86/kernel/setup.c 2012-03-04 03:46:35.000000000 +0800
+++ linux-2.6/arch/x86/kernel/setup.c 2012-03-10 12:44:58.133300788 +0800
@@ -509,15 +509,6 @@ static void __init memblock_x86_reserve_
#ifdef CONFIG_KEXEC
-static inline unsigned long long get_total_mem(void)
-{
- unsigned long long total;
-
- total = max_pfn - min_low_pfn;
-
- return total << PAGE_SHIFT;
-}
-
/*
* Keep the crash kernel below this limit. On 32 bits earlier kernels
* would limit the kernel to the low 512 MiB due to mapping restrictions.
@@ -536,7 +527,7 @@ static void __init reserve_crashkernel(v
unsigned long long crash_size, crash_base;
int ret;
- total_mem = get_total_mem();
+ total_mem = memblock_phys_mem_size();
ret = parse_crashkernel(boot_command_line, total_mem,
&crash_size, &crash_base);
next prev parent reply other threads:[~2012-03-10 4:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 8:30 [PATCH] " Dave Young
2012-03-10 3:27 ` Cong Wang
2012-03-10 4:32 ` Dave Young
2012-03-10 4:56 ` Dave Young [this message]
2012-03-10 8:38 ` [PATCH v2] " Cong Wang
2012-03-10 16:06 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120310045632.GA4214@darkstar.redhat.com \
--to=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome