From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754318Ab2CKWqj (ORCPT ); Sun, 11 Mar 2012 18:46:39 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:41850 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517Ab2CKWqb (ORCPT ); Sun, 11 Mar 2012 18:46:31 -0400 Date: Sun, 11 Mar 2012 15:42:19 -0700 (PDT) Message-Id: <20120311.154219.270150852508281564.davem@davemloft.net> To: julia.lawall@lip6.fr Cc: chas@cmf.nrl.navy.mil, kernel-janitors@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible From: David Miller In-Reply-To: References: <201203112058.q2BKwBCS024617@cmf.nrl.navy.mil> X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Sun, 11 Mar 2012 15:42:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Date: Sun, 11 Mar 2012 22:16:25 +0100 (CET) > From: Julia Lawall > > Convert calls to free_irq so that the second argument is the same as > the > last argument of the corresponding call to request_irq. Without this > property, free_irq does nothing. > > Signed-off-by: Julia Lawall Applied, but this driver also has a larger problem, it doesn't free the IRQ (nor do any other kind of chip shutdown and cleanups) when the driver is unloaded. The unload function is just one empty function with a comment.