From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: Convert printks to pr_<level>
Date: Sun, 11 Mar 2012 23:48:46 -0700 (PDT) [thread overview]
Message-ID: <20120311.234846.455580505379366792.davem@davemloft.net> (raw)
In-Reply-To: <1331526971.13200.9.camel@joe2Laptop>
From: Joe Perches <joe@perches.com>
Date: Sun, 11 Mar 2012 21:36:11 -0700
> Use a more current kernel messaging style.
>
> Convert a printk block to print_hex_dump.
> Coalesce formats, align arguments.
> Use %s, __func__ instead of embedding function names.
>
> Some messages that were prefixed with <foo>_close are
> now prefixed with <foo>_fini. Some ah4 and esp messages
> are now not prefixed with "ip ".
>
> The intent of this patch is to later add something like
> #define pr_fmt(fmt) "IPv4: " fmt.
> to standardize the output messages.
>
> Text size is trivially reduced. (x86-32 allyesconfig)
>
> $ size net/ipv4/built-in.o*
> text data bss dec hex filename
> 887888 31558 249696 1169142 11d6f6 net/ipv4/built-in.o.new
> 887934 31558 249800 1169292 11d78c net/ipv4/built-in.o.old
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks a lot Joe.
next prev parent reply other threads:[~2012-03-12 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 4:36 Joe Perches
2012-03-12 6:48 ` David Miller [this message]
2012-03-12 17:03 ` [PATCH net-next] net: ipv4: Standardize prefixes for message logging Joe Perches
2012-03-13 0:05 ` David Miller
2012-03-13 0:35 ` Joe Perches
2012-03-19 21:00 ` Joe Perches
2012-03-19 21:03 ` David Miller
2012-03-19 21:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311.234846.455580505379366792.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®