From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755447Ab2CLNJU (ORCPT ); Mon, 12 Mar 2012 09:09:20 -0400 Received: from csmtp2.one.com ([91.198.169.22]:55709 "EHLO csmtp2.one.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214Ab2CLNJT (ORCPT ); Mon, 12 Mar 2012 09:09:19 -0400 X-Greylist: delayed 507 seconds by postgrey-1.27 at vger.kernel.org; Mon, 12 Mar 2012 09:09:18 EDT From: "Henrik Rydberg" Date: Mon, 12 Mar 2012 14:02:33 +0100 To: Jiri Kosina Cc: Benjamin Tissoires , Dmitry Torokhov , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] HID: multitouch: add support for eGalax 0x722a Message-ID: <20120312130233.GA7456@polaris.bitmath.org> References: <1331053026-21272-1-git-send-email-benjamin.tissoires@gmail.com> <1331053026-21272-2-git-send-email-benjamin.tissoires@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Thanks Jiri. > > How about patches 2,3 and 5? > > I just needed some more time to review those. They are now in my tree as > well. > > Patch #4 is still under discussion, and thus on hold. I am ok with the approach, given that a better one would require a substantial amount of extra work. Also, since this is all internal changes, the current patchset does not hinder an eventual improvement later on. For patch 3, it would be good to at least put the test for the hid-multitouch driver in a separate function. For patch 4, the variable name "multitouch" is a bit too generic given the very specific usage. Thanks, Henrik