From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755482Ab2CLOVr (ORCPT ); Mon, 12 Mar 2012 10:21:47 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:33371 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752306Ab2CLOVp (ORCPT ); Mon, 12 Mar 2012 10:21:45 -0400 Date: Mon, 12 Mar 2012 14:21:43 +0000 From: Mark Brown To: Thomas Abraham Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org, kgene.kim@samsung.com, patches@linaro.org Subject: Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface Message-ID: <20120312142143.GC14020@sirena.org.uk> References: <1331469965-28846-1-git-send-email-thomas.abraham@linaro.org> <1331469965-28846-6-git-send-email-thomas.abraham@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331469965-28846-6-git-send-email-thomas.abraham@linaro.org> X-Cookie: Yow! Are we laid back yet? User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Scanned: No (on cassiel.sirena.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 11, 2012 at 06:16:05PM +0530, Thomas Abraham wrote: > The platform specific callback to setup the sdhci pin mux and pin config > is removed and the pinctrl subsystem interface is used to setup the > mux and config. You've only added pinctrl support for Exynos but this driver is also used by SoCs going back to s3c24xx era. Either all those SoCs need to be converted to use pinctrl or the driver needs to understand both methods (eg, using pinctrl if no callback is supplied).