mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: myungjoo.ham@gmail.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kevin Hilman <khilman@ti.com>, Mike Turquette <mturquette@ti.com>
Subject: Re: [PATCH] PM / devfreq: add relation of recommended frequency.
Date: Tue, 13 Mar 2012 00:46:03 +0100	[thread overview]
Message-ID: <201203130046.03838.rjw@sisk.pl> (raw)
In-Reply-To: <CAJ0PZbSXzkvkOjWw66k5ZrtksQxiF0HwcFZ4jHKs9=4XodszVg@mail.gmail.com>

On Monday, March 12, 2012, MyungJoo Ham wrote:
> 2012/3/11 Rafael J. Wysocki <rjw@sisk.pl>:
> > On Wednesday, March 07, 2012, MyungJoo Ham wrote:
> >> The semantics of "target frequency" given to devfreq driver from
> >> devfreq framework has always been interpretted as "at least" or GLB
> >> (greatest lower bound). However, the framework might want the
> >> device driver to limit its max frequency (LUB: least upper bound),
> >> especially if it is given by thermal framework (it's too hot).
> >>
> >> Thus, the target fuction should have another parameter to express
> >> whether the framework wants GLB or LUB. And, the additional parameter,
> >> "u32 options", does it.
> >>
> >> With the update, devfreq_recommended_opp() is also updated.
> >>
> >> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >
> > This one looks good.
> >
> > Do you want me to take it as a patch, or to pull it from your tree?
> >
> > Rafael
> 
> Hello Rafael,
> 
> 
> Please pull it from the tree
> (http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/devfreq-for-next)
> as the change log has been corrected.
> 
> git://git.infradead.org/users/kmpark/linux-samsung devfreq-for-next

I'm not happy with the "PM / devfreq: add PM QoS support" commit, however.

I believe I explained the reason why in a separate message sent a couple of
days ago.

Thanks,
Rafael

  reply	other threads:[~2012-03-12 23:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10  7:19 MyungJoo Ham
2012-02-29 22:59 ` Rafael J. Wysocki
2012-03-05  7:44   ` MyungJoo Ham
2012-03-07  7:40   ` MyungJoo Ham
2012-03-10 21:51     ` Rafael J. Wysocki
2012-03-12  2:12       ` MyungJoo Ham
2012-03-12 23:46         ` Rafael J. Wysocki [this message]
2012-03-15  0:25     ` Rafael J. Wysocki
2012-03-16  6:02       ` [PATCH v3] " MyungJoo Ham
2012-03-16  6:14         ` Turquette, Mike
2012-03-16 21:07           ` Rafael J. Wysocki
2012-03-07 17:45 ` [PATCH] " Turquette, Mike
2012-03-09  7:09   ` MyungJoo Ham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203130046.03838.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=khilman@ti.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mturquette@ti.com \
    --cc=myungjoo.ham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®