mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "'Greg KH'" <gregkh@linuxfoundation.org>
To: Donald <donald@asix.com.tw>
Cc: "'open list:USB SUBSYSTEM'" <linux-usb@vger.kernel.org>,
	"'open list'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] x86: Fixed MCS7820 device attach problem
Date: Tue, 13 Mar 2012 09:09:51 -0700	[thread overview]
Message-ID: <20120313160951.GA18810@kroah.com> (raw)
In-Reply-To: <009c01cd00ee$924eb2e0$b6ec18a0$@com.tw>

On Tue, Mar 13, 2012 at 03:54:46PM +0800, Donald wrote:
> A MCS7820 device supports two serial ports and a MCS7840 device supports
> four serial ports. Both devices use the same driver, but the attach function
> in driver was unable to correctly handle the port numbers for MCS7820
> device. This problem has been fixed in this patch and this fix has been
> verified on x86 Linux kernel 3.2.9 with both MCS7820 and MCS7840 devices.
> 
> Signed-off-by: Donald Lee <donald@asix.com.tw> 
> 
> --- 
>  drivers/usb/serial/mos7840.c |   83
> +++++++++++++++++++++++++++++------------- 

This is great, but your email client turned the tabs into spaces and
line-wrapped the patch, and added trailing spaces on every line, making
this impossible to apply :(

Care to read Documentation/email_clients.txt and resend it after fixing
things up on your end?

And this isn't limited to x86, so you don't need that in the subject:
line, it's a USB issue for all platforms.

thanks,

greg k-h

  reply	other threads:[~2012-03-13 16:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13  7:54 Donald
2012-03-13 16:09 ` 'Greg KH' [this message]
2012-03-29 13:33   ` Patch "USB: serial: mos7840: Supported MCS7810 device" Donald
2012-03-29 15:04     ` Alan Cox
2012-03-30  2:16       ` Donald
2012-03-29 15:13     ` 'Greg KH'
2012-03-30  2:21       ` Donald
2012-04-11  9:32       ` Donald
2012-04-11 11:08         ` Johan Hovold
2012-04-11 11:43           ` Donald
2012-04-11 14:03         ` 'Greg KH'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313160951.GA18810@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=donald@asix.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome