From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 3/6] tracing: Keep NMI watchdog from triggering when dumping trace
Date: Wed, 14 Mar 2012 12:26:32 -0400 [thread overview]
Message-ID: <20120314162708.584325126@goodmis.org> (raw)
In-Reply-To: <20120314162629.118638243@goodmis.org>
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
As ftrace_dump() (called by ftrace_dump_on_oops) disables interrupts
as it dumps its output to the console, it can keep interrupts disabled
for long periods of time. This is likely to trigger the NMI watchdog,
and it can disrupt the output of critical data.
Add a touch_nmi_watchdog() to each event that is written to the screen
to keep the NMI watchdog from affecting the output.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index f3c13d6..3a19c35 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -36,6 +36,7 @@
#include <linux/ctype.h>
#include <linux/init.h>
#include <linux/poll.h>
+#include <linux/nmi.h>
#include <linux/fs.h>
#include "trace.h"
@@ -4903,6 +4904,7 @@ __ftrace_dump(bool disable_tracing, enum ftrace_dump_mode oops_dump_mode)
if (ret != TRACE_TYPE_NO_CONSUME)
trace_consume(&iter);
}
+ touch_nmi_watchdog();
trace_printk_seq(&iter.seq);
}
--
1.7.8.3
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-14 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 16:26 [PATCH 0/6] [GIT PULL] tracing: updates Steven Rostedt
2012-03-14 16:26 ` [PATCH 1/6] tracing/ring-buffer: Only have tracing_on disable tracing buffers Steven Rostedt
2012-03-14 16:26 ` [PATCH 2/6] tracing: Do not select FRAME_POINTER on PPC Steven Rostedt
2012-03-14 16:26 ` Steven Rostedt [this message]
2012-03-14 16:26 ` [PATCH 4/6] ftrace: Fix function_graph for archs that test ftrace_trace_function Steven Rostedt
2012-03-14 16:26 ` [PATCH 5/6] tracing: Fix build breakage without CONFIG_PERF_EVENTS Steven Rostedt
2012-03-14 16:26 ` [PATCH 6/6] perf: Add ifdef to remove unused enum switch warnings Steven Rostedt
2012-03-19 10:59 ` [PATCH 0/6] [GIT PULL] tracing: updates Ingo Molnar
2012-03-19 14:46 ` Ingo Molnar
2012-03-20 13:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314162708.584325126@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome