From: David Howells <dhowells@redhat.com>
To: msalter@redhat.com, a-jacquiot@ti.com
Cc: linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>
Subject: [PATCH] Fix c6x's entry.S
Date: Thu, 15 Mar 2012 17:52:22 +0000 [thread overview]
Message-ID: <20120315175222.32354.43890.stgit@warthog.procyon.org.uk> (raw)
The ENDPROC() on sys_fadvise64_c6x() in arch/c6x/kernel/entry.S needs to be
transposed with the preceding #endif so that it's in the same conditional
block as the matching ENTRY() macro.
Without this, I see:
/tmp/ccGZBaPT.s: Assembler messages:
/tmp/ccGZBaPT.s: Error: .size expression for sys_fadvise64_c6x does not evaluate to a constant
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/c6x/kernel/entry.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
index 3e977cc..91b2e79 100644
--- a/arch/c6x/kernel/entry.S
+++ b/arch/c6x/kernel/entry.S
@@ -741,8 +741,8 @@ ENTRY(sys_fadvise64_c6x)
#endif
MV .D1X B6,A6
MV .D2X A8,B6
-#endif
ENDPROC(sys_fadvise64_c6x)
+#endif
;; On Entry
;; A4 - fd
next reply other threads:[~2012-03-15 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 17:52 David Howells [this message]
2012-03-15 18:34 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315175222.32354.43890.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=a-jacquiot@ti.com \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®