Re: [PATCH] TTY: Wrong unicode value copied in con_set_unimap()

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 15, 2012 at 07:36:34PM +0000, Clark, Liz wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Thursday, March 15, 2012 11:55 AM
> > To: Clark, Liz
> > Cc: linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] TTY: Wrong unicode value copied in
> > con_set_unimap()
> > 
> > On Thu, Mar 15, 2012 at 10:33:29AM -0700, Liz Clark wrote:
> > > Bugzilla 40012: PIO_UNIMAP bug: error updating Unicode-to-font map
> > >
> > > The unicode font map for the virtual console is a 32x32x64 table
> > which
> > > allocates rows dynamically as entries are added.  The unicode value
> > > increases sequentially and should count all entries even in empty
> > > rows.  The defect is when copying the unicode font map in
> > con_set_unimap(),
> > > the unicode value is not incremented properly.  The wrong unicode
> > value
> > > is entered in the new font map.
> > >
> > > Signed-off-by: Liz Clark <liz.clark@hp.com>
> > 
> > Is this a new problem caused by recent changes in this area, or has it
> > always been there and needs to be backported to older kernels to solve
> > the problem there?
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> The code with the defect was introduced in v2.1.112.  Prior to that
> the fontmap was not copied at all in con_set_unimap().

Ok, as this has been with us for a few years, it can wait for 3.4 to go
in, and I'll mark it for stable to get it applied backwards as far as it
can go.

thanks,

greg k-h