mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Keith Packard <keithp@keithp.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Benson Leung <bleung@chromium.org>,
	Yufeng Shen <miletus@chromium.org>,
	Sameer Nanda <snanda@chromium.org>
Subject: Re: [PATCH 00/10 v2] fix gmbus writes and related issues
Date: Sun, 18 Mar 2012 19:22:05 +0100	[thread overview]
Message-ID: <20120318182204.GH4286@phenom.ffwll.local> (raw)
In-Reply-To: <1331318904-20577-1-git-send-email-djkurtz@chromium.org>

On Sat, Mar 10, 2012 at 02:48:14AM +0800, Daniel Kurtz wrote:
> This patchset addresses a couple of issues with the i915 gmbus implementation:
>  * fixes misassigned pin port pair for HDMI-D
>  * fixes write transactions when they are the only transaction requested
>    (including large >4-byte writes) by terminating every transaction with a
>    WAIT cycle.
>  * returns -ENXIO and -ETIMEDOUT as appropriate so upper layers can handled
>    i2c transaction failures
>  * optimizes the typical read transaction case by using the INDEX cycle
>  * turns on the GMBUS interrupt whenever possible to dramatically improve
>    throughput by eliminating the very slow polling loop.
> 
> The patchset should apply cleanly onto linus/master.
> It is inspired by, but completely supercedes, a similar patch submitted
> recently by Benson Leung (bleung@chromium.org).
> I'd be happy to rebase on a different tree if necessary.
> 
> v2 of the patchset address review comments from Chris Wilson (thanks for the
> review, Chris!), and adds the interrupt patch.  There weren't any review
> comments for patches 5, 7, or 8 of the first set.  Hopefully they will get
> more love the second time around :).

Oops, still catching up - I've commented on the first thread. Please
resubmit on top of drm-intel-next-queued and I'll have a look. Also,
please cc me so I don't miss them.

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  parent reply	other threads:[~2012-03-18 18:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-09 18:48 Daniel Kurtz
2012-03-09 18:48 ` [PATCH 01/10 v2] drm/i915/intel_i2c: cleanup Daniel Kurtz
2012-03-09 18:48 ` [PATCH 02/10 v2] drm/i915/intel_i2c: assign HDMI port D to pin pair 6 Daniel Kurtz
2012-03-09 18:48 ` [PATCH 03/10 v2] drm/i915/intel_i2c: add intel_gmbus_get_adapter Daniel Kurtz
2012-03-09 18:48 ` [PATCH 04/10 v2] drm/i915/intel_i2c: cleanup gmbus/gpio pin assignments Daniel Kurtz
2012-03-09 18:48 ` [PATCH 05/10 v2] drm/i915/intel_i2c: add locking around i2c algorithm accesses Daniel Kurtz
2012-03-09 18:48 ` [PATCH 06/10 v2] drm/i915/intel_i2c: return -ENXIO for device NAK Daniel Kurtz
2012-03-09 18:48 ` [PATCH 07/10 v2] drm/i915/intel_i2c: use WAIT cycle, not STOP Daniel Kurtz
2012-03-09 18:48 ` [PATCH 08/10 v2] drm/i915/intel_i2c: use INDEX cycles for i2c read transactions Daniel Kurtz
2012-03-09 18:48 ` [PATCH 09/10 v2] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop Daniel Kurtz
2012-03-09 18:48 ` [PATCH 10/10 v2] drm/i915/intel_i2c: enable gmbus interrupts Daniel Kurtz
2012-03-18 18:22 ` Daniel Vetter [this message]
2012-03-24 19:33   ` [PATCH 00/10 v2] fix gmbus writes and related issues Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120318182204.GH4286@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=bleung@chromium.org \
    --cc=djkurtz@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miletus@chromium.org \
    --cc=snanda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®