From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760160Ab2CTORd (ORCPT ); Tue, 20 Mar 2012 10:17:33 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:59046 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760045Ab2CTORc (ORCPT ); Tue, 20 Mar 2012 10:17:32 -0400 Date: Tue, 20 Mar 2012 22:18:14 +0800 From: Shawn Guo To: Sascha Hauer Cc: Saravana Kannan , Mike Turquette , Arnd Bergman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andrew Lunn , Rob Herring , Russell King , Jeremy Kerr , Thomas Gleixner , Paul Walmsley , Shawn Guo , Jamie Iles , Richard Zhao , Magnus Damm , Mark Brown , Linus Walleij , Stephen Boyd , Amit Kucheria , Deepak Saxena , Grant Likely Subject: Re: [PATCH 2/2] clk: Move init fields from clk to clk_hw Message-ID: <20120320141811.GF32469@S2101-09.ap.freescale.net> References: <1332214706-675-1-git-send-email-skannan@codeaurora.org> <1332214706-675-2-git-send-email-skannan@codeaurora.org> <20120320072018.GC32469@S2101-09.ap.freescale.net> <20120320094031.GI3852@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120320094031.GI3852@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 20, 2012 at 10:40:31AM +0100, Sascha Hauer wrote: ... > I am using these functions and don't need a static array, I just call > the functions with the desired parameters. > With this patch getting in, you do not have to use them then. I feel a static array will be much more readable than a long list of function calls with a long list of hardcoded arguments to each. -- Regards, Shawn