From: Tejun Heo <tj@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
ctalbott@google.com, rni@google.com
Subject: Re: [PATCHSET] block: remove ioc_*_changed()
Date: Tue, 20 Mar 2012 08:53:58 -0700 [thread overview]
Message-ID: <20120320155358.GB5684@google.com> (raw)
In-Reply-To: <20120320155118.GC17071@redhat.com>
On Tue, Mar 20, 2012 at 11:51:18AM -0400, Vivek Goyal wrote:
> So this patch still breaks cic->cfqq association in asynchronous
> manner, when new request comes in. So it will still not solve the
> problem I reported where after doing IO a task changes cgroup and
> tries to delete the old cgroup and hangs forever as cic->cfqq is still
> holding a reference to cgroup?
That one is gonna have to be fixed from cgroup side. I already posted
a RFC patchset (you were cc'd there, I think). At the moment, the
blocking thing is memcg's ->pre_destroy() usage. I'll ping memcg
people once more and if modification there isn't feasible, will
implement a workaround in cgroup core.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-03-20 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 22:10 Tejun Heo
2012-03-19 22:10 ` [PATCH 1/4] blkcg: add blkcg->id Tejun Heo
2012-03-19 22:10 ` [PATCH 2/4] cfq: pass around cfq_io_cq instead of io_context Tejun Heo
2012-03-19 22:10 ` [PATCH 3/4] cfq: don't use icq_get_changed() Tejun Heo
2012-03-19 22:10 ` [PATCH 4/4] block: remove ioc_*_changed() Tejun Heo
2012-03-20 11:49 ` [PATCHSET] " Jens Axboe
2012-03-20 15:51 ` Vivek Goyal
2012-03-20 15:53 ` Tejun Heo [this message]
2012-03-20 16:00 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320155358.GB5684@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rni@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome