From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983Ab2CWHFs (ORCPT ); Fri, 23 Mar 2012 03:05:48 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:47765 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755536Ab2CWHFo (ORCPT ); Fri, 23 Mar 2012 03:05:44 -0400 Date: Fri, 23 Mar 2012 09:04:46 +0200 From: Mika Westerberg To: H Hartley Sweeten Cc: Rafal Prylowski , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "vinod.koul@intel.com" , "rmallon@gmail.com" Subject: Re: [PATCH] ep93xx: Implement double buffering for M2M DMA channels Message-ID: <20120323070446.GC5812@mwesterb-mobl.ger.corp.intel.com> References: <4F683B36.8090101@metasoft.pl> <20120321193836.GC3740@mwesterb-mobl.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 22, 2012 at 09:19:10PM -0500, H Hartley Sweeten wrote: > Did you test this patch or just review it? I tested and reviewed it. > On my system it doesn't work. I think it has something to do with the > changes to m2m_hw_interrupt but I haven't tracked it down yet. > > It looks like what's missing is a: > > edmac->edma->hw_submit(edmac); > > But, maybe that's not needed with double buffering? Did you try without your patch and adding my VIC hack? That's what I did when I first got this patch and I saw no problems. I tested with audio (M2P), mmc_spi (M2M) and dmatest (M2M).