From: David Miller <davem@davemloft.net>
To: consul.kautuk@gmail.com
Cc: paul.gortmaker@windriver.com, mingo@elte.hu, joe@perches.com,
a.p.zijlstra@chello.nl, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20 v2] sparc/mm/fault_32.c: Port OOM changes to do_sparc_fault
Date: Sun, 25 Mar 2012 15:04:22 -0400 (EDT) [thread overview]
Message-ID: <20120325.150422.2000357641354896689.davem@davemloft.net> (raw)
In-Reply-To: <1332698315-2218-1-git-send-email-consul.kautuk@gmail.com>
From: Kautuk Consul <consul.kautuk@gmail.com>
Date: Sun, 25 Mar 2012 13:58:35 -0400
> + unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> + (write ? FAULT_FLAG_WRITE : 0));
Still indented wrong, it should be:
unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
(write ? FAULT_FLAG_WRITE : 0));
The second line must have the openning parenthesis line up with
the column after the openning parenthesis on the first line. Do
not use only tabs to indent this stuff, line it up properly.
You need to use tabs and spaces to line it up. Use something like
emacs's C-mode to help you if you can't do it right by hand.
> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
> + 1, regs, address);
Still wrong, for the same exact reason.
I went out of my way to reply to your private email (which I usually
ignore, you should never email developers privately) and you didn't
even listen to the feedback I gave you.
next prev parent reply other threads:[~2012-03-25 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 17:58 Kautuk Consul
2012-03-25 19:04 ` David Miller [this message]
2012-03-26 15:35 ` Kautuk Consul
2012-03-26 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120325.150422.2000357641354896689.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=consul.kautuk@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paul.gortmaker@windriver.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®