From: David Miller <davem@davemloft.net>
To: consul.kautuk@gmail.com
Cc: paul.gortmaker@windriver.com, mingo@elte.hu, joe@perches.com,
a.p.zijlstra@chello.nl, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to do_sparc_fault
Date: Mon, 26 Mar 2012 16:09:23 -0400 (EDT) [thread overview]
Message-ID: <20120326.160923.1071907261787727015.davem@davemloft.net> (raw)
In-Reply-To: <1332775946-2162-1-git-send-email-consul.kautuk@gmail.com>
From: Kautuk Consul <consul.kautuk@gmail.com>
Date: Mon, 26 Mar 2012 11:32:26 -0400
> + unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> + (write ? FAULT_FLAG_WRITE : 0));
Indentation is still wrong. The "(write ..." on the second line must
line up with the column of the first "F" in "(FAULT_FLAG..." on the
first line.
+ perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
+ 1, regs, address);
+ perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN,
+ 1, regs, address);
These are still wrong too, for the same reason.
You didn't fix anything.
prev parent reply other threads:[~2012-03-26 20:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 15:32 Kautuk Consul
2012-03-26 16:16 ` Joe Perches
2012-03-26 16:20 ` Kautuk Consul
2012-03-26 16:32 ` Joe Perches
2012-03-26 16:55 ` Kautuk Consul
2012-03-26 17:03 ` Joe Perches
2012-03-26 17:05 ` Kautuk Consul
2012-03-26 16:36 ` Sam Ravnborg
2012-03-26 20:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326.160923.1071907261787727015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=consul.kautuk@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paul.gortmaker@windriver.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®