From: David Miller <davem@davemloft.net>
To: consul.kautuk@gmail.com
Cc: paul.gortmaker@windriver.com, mingo@elte.hu, joe@perches.com,
a.p.zijlstra@chello.nl, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 20/20 v3] sparc/mm/fault_64.c: Port OOM changes to do_sparc64_fault
Date: Mon, 26 Mar 2012 16:11:05 -0400 (EDT) [thread overview]
Message-ID: <20120326.161105.1592652605352070253.davem@davemloft.net> (raw)
In-Reply-To: <1332775997-2197-1-git-send-email-consul.kautuk@gmail.com>
From: Kautuk Consul <consul.kautuk@gmail.com>
Date: Mon, 26 Mar 2012 11:33:17 -0400
> + fault = handle_mm_fault(mm, vma, address,
> + flags | ((fault_code & FAULT_CODE_WRITE) ?
> + FAULT_FLAG_WRITE : 0);
This is so shockingly gross I'm at a loss for words. Why are you
tabbing this crap all the way into outer-space?
Make the "flags | ..." line up with the first column after the
openning parenthesis of "handle_mm_fault(".
> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
> + 1, regs, address);
Same problem.
> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN,
> + 1, regs, address);
Same problem.
You're making the coding style worse each iteration, not better.
prev parent reply other threads:[~2012-03-26 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 15:33 Kautuk Consul
2012-03-26 16:31 ` Joe Perches
2012-03-26 16:50 ` Kautuk Consul
2012-03-26 20:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326.161105.1592652605352070253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=consul.kautuk@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paul.gortmaker@windriver.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®