From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Wang YanQing <udknight@gmail.com>
Cc: FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, spock@gentoo.org
Subject: Re: [PATCH] video:uvesafb: Fix oops that uvesafb try to execute NX-protected page
Date: Tue, 27 Mar 2012 14:32:43 +0100 [thread overview]
Message-ID: <20120327143243.015ecff6@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120327100136.GA3829@udknight>
On Tue, 27 Mar 2012 18:01:36 +0800
Wang YanQing <udknight@gmail.com> wrote:
>
> Ok! I try to check pcibios_enabled first, but get some opposition by Alan Cox,
> but I want to make thing work and fix the oops, so I choice the simple way to
> check the (__supported_pte_mask & _PAGE_NX) instead of to check this variable plus
> pci kernel boot parameter, pci mmconfig works or not, and more, and more. It is not
> the best method, but it works and maybe all will feel happy.
Okay let me ask the obvious question - why is it not the best method ?
Apart from adding a helper in the includes for the arch code of
static inline is_nx_enabled(void)
{
return !!(__supported_pte_mask & _PAGE_NX);
}
is there anything else it lacks ?
Yes ideally we'd set the relevant ROM areas executable, but for a simple
fix is there anything else that's a problem with it ?
Alan
next prev parent reply other threads:[~2012-03-27 13:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 10:01 Wang YanQing
2012-03-27 13:32 ` Alan Cox [this message]
2012-03-28 0:52 ` Wang YanQing
2012-04-01 1:05 ` Wang YanQing
2012-04-10 6:49 ` Wang YanQing
2012-04-10 14:28 ` Alan Cox
2012-03-28 15:36 ` Hein_Tibosch
2012-03-31 21:31 ` Florian Tobias Schandinat
-- strict thread matches above, loose matches on Subject: below --
2012-04-01 0:54 Wang YanQing
2012-04-12 2:22 ` Florian Tobias Schandinat
2012-04-01 0:47 Wang YanQing
2012-04-01 0:55 ` Wang YanQing
2012-03-02 0:48 Wang YanQing
2012-03-05 0:52 ` Wang YanQing
2012-03-05 7:09 ` Florian Tobias Schandinat
2012-03-05 7:25 ` Wang YanQing
2012-03-09 0:39 ` Michal Januszewski
2012-03-21 18:34 ` Florian Tobias Schandinat
2012-02-29 13:38 Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327143243.015ecff6@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spock@gentoo.org \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome