mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tao Ma <tm@tao.ma>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: Make cfq_target_latency tunable through sysfs.
Date: Wed, 28 Mar 2012 17:32:28 -0700	[thread overview]
Message-ID: <20120329003228.GA18424@kroah.com> (raw)
In-Reply-To: <1332836213-5266-1-git-send-email-tm@tao.ma>

On Tue, Mar 27, 2012 at 04:16:53PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> In cfq, when we calculate a time slice for a process(or a cfqq to
> be precise), we have to consider the cfq_target_latency so that all the
> sync request have an estimated latency(300ms) and it is controlled by
> cfq_target_latency. But in some hadoop test, we have found that if
> there are many processes doing sequential read(24 for example), the
> throughput is bad because every process can only work for about 25ms
> and the cfqq is switched. That leads to a higher disk seek. We can
> achive the good throughput by setting low_latency=0, but then some
> read's latency is too much for the application.
> 
> So this patch makes cfq_target_latency tunable through sysfs so that
> we can tune it and find some magic number which is not bad for both
> the throughput and the read latency.

If you add/modify sysfs files, you HAVE to also have a matching change
to Documentation/ABI.

Please do so.

thanks,

greg k-h

  reply	other threads:[~2012-03-29  0:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  8:16 Tao Ma
2012-03-29  0:32 ` Greg KH [this message]
2012-03-29  0:36   ` Tao Ma
2012-03-29 10:38     ` Jens Axboe
2012-03-31 15:31 ` [PATCH V2 1/2] " Tao Ma
2012-03-31 15:31   ` [PATCH V2 2/2] Documentation: Add sysfs ABI change for cfq's target latency Tao Ma
2012-04-01 21:33   ` [PATCH V2 1/2] block: Make cfq_target_latency tunable through sysfs Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120329003228.GA18424@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tm@tao.ma \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome