From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757841Ab2C2JP2 (ORCPT ); Thu, 29 Mar 2012 05:15:28 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:53826 "EHLO violet" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750932Ab2C2JPU (ORCPT ); Thu, 29 Mar 2012 05:15:20 -0400 Date: Thu, 29 Mar 2012 11:12:29 +0200 From: Francois Romieu To: Hayes Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 5/5] r8169: support RTL8411 Message-ID: <20120329091229.GA22410@electric-eye.fr.zoreil.com> References: <1332923214-5071-1-git-send-email-hayeswang@realtek.com> <1332923214-5071-5-git-send-email-hayeswang@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1332923214-5071-5-git-send-email-hayeswang@realtek.com> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hayes Wang : > Support the new chip RTL8411. > > Signed-off-by: Hayes Wang > --- > drivers/net/ethernet/realtek/r8169.c | 142 +++++++++++++++++++++++++++++++++- > 1 files changed, 139 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index cde5cea..d00f4e9 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -250,7 +252,10 @@ static const struct { > JUMBO_9K, false), > [RTL_GIGA_MAC_VER_37] = > _R("RTL8402", RTL_TD_1, FIRMWARE_8402_1, > - JUMBO_1K, true) > + JUMBO_1K, true), > + [RTL_GIGA_MAC_VER_38] = > + _R("RTL8411", RTL_TD_1, FIRMWARE_8411_1, > + JUMBO_9K, false) rtl_init_jumbo_ops probably needs to be updated as well. Nit: please keep a colon in 'JUMBO_9K, false),'. ^ There was one after the (not so) last record before patch 03/05 and I would prefer it to stay because new devices are regularly added. The '-' line is only noise. Thanks. -- Ueimor