mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Daniel Walker <dwalker@fifo99.com>
Cc: Tim Bird <tim.bird@am.sony.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-team@android.com" <kernel-team@android.com>
Subject: Re: [RFC] Android Logger vs. Shared Memory FIGHT!
Date: Thu, 29 Mar 2012 19:50:07 +0100	[thread overview]
Message-ID: <20120329195007.07d53db7@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120329175209.GE16476@fifo99.com>

On Thu, 29 Mar 2012 10:52:10 -0700
Daniel Walker <dwalker@fifo99.com> wrote:

> On Thu, Mar 29, 2012 at 09:25:26AM -0700, Tim Bird wrote:
> > At the moment, I'm not considering an alternative for logger that runs
> > completely in user-space.  Having said that, this test is certainly interesting,
> > and may provide some performance numbers for logger or alternatives that would
> > be useful to compare.
> 
> 
> I was just thinking what does an accurate PID actually get you? If you
> looking at some logs with a PID of 20048, does that mean something to
> you? It doesn't actually mean much because you can't map that back to
> anything. If you have the device, and the process is still running then
> you could look it up ..
> 
> So lets say logger was modified to record comm values.. That way you
> could record the actual process name AND the pid. Well if you use
> prctl(PR_SET_NAME), you can forge comm values. So that doesn't get you
> much either..
> 
> So even if you record accurate PID values, it doesn't mean anything
> anyway.

The question is whether you are trying to record data for analysis in a
hostile environment or you are trying to do useful debugging. If your
apps are non hostile then PR_SET_NAME is actually useful in logging to
split apart different executions of the same daemon.

The Android logger has no security model of any real kind so it's clearly
about the debug side. In that case the PID lets you correlate with other
logs, the comm data might be useful.

Alan

  parent reply	other threads:[~2012-03-29 18:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 21:06 Daniel Walker
2012-03-28 21:10 ` Daniel Walker
2012-03-29 14:50 ` Daniel Walker
2012-03-29 16:25   ` Tim Bird
2012-03-29 17:09     ` Daniel Walker
2012-03-29 17:43       ` Tim Bird
2012-03-29 17:52     ` Daniel Walker
2012-03-29 18:20       ` Tim Bird
2012-03-29 18:30         ` Daniel Walker
2012-03-29 18:50       ` Alan Cox [this message]
2012-03-29 19:09         ` Daniel Walker
2012-03-29 22:19         ` Tim Bird
2012-03-29 22:58           ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120329195007.07d53db7@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=dwalker@fifo99.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome