From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760045Ab2C2Uqu (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Mar 2012 16:46:50 -0400
Received: from mail.skyhub.de ([78.46.96.112]:34321 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933744Ab2C2Uq2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Mar 2012 16:46:28 -0400
Date: Thu, 29 Mar 2012 22:46:23 +0200
From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Matt Fleming <matt.fleming@intel.com>,
        Trevor Turner <turn3r.tr3v0r@gmail.com>,
        Randy Dunlap <rdunlap@xenotime.net>, linux-kernel@vger.kernel.org,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: K7/Athlon Optimization Causes Build Fail on Kernel 3.3 i686
Message-ID: <20120329204622.GA8655@liondog.tnic>
Mail-Followup-To: Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Matt Fleming <matt.fleming@intel.com>,
	Trevor Turner <turn3r.tr3v0r@gmail.com>,
	Randy Dunlap <rdunlap@xenotime.net>, linux-kernel@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>
References: <CANYHJ6jjuO7yV_kbPsnJ6X+KXrsz2PRPPXHN4Rkr-vgoSG-E4A@mail.gmail.com>
 <20120328111957.GA6765@x1.osrc.amd.com>
 <CANYHJ6j6cxz47TGk8kdU58eau17Fi1K=fH2icmd=v19VjNggKw@mail.gmail.com>
 <20120328171059.GA7919@x1.osrc.amd.com>
 <4F7346BB.9020907@xenotime.net>
 <20120328172759.GC6765@x1.osrc.amd.com>
 <20120329074802.GA31955@liondog.tnic>
 <1333008855.4289.3.camel@mfleming-mobl1.ger.corp.intel.com>
 <20120329104822.GA17233@x1.osrc.amd.com>
 <4F74A9D8.1040808@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4F74A9D8.1040808@zytor.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 29, 2012 at 11:28:40AM -0700, H. Peter Anvin wrote:
> I like this one for urgent as a quick fix, but it doesn't solve the real
> problem which is that boot/compressed shouldn't pick up these macros at all.

But it does through:

<arch/x86/include/asm/string_32.h>:

...
static inline void *__memcpy3d(void *to, const void *from, size_t len)
{
	if (len < 512)
		return __memcpy(to, from, len);
	return _mmx_memcpy(to, from, len);
}

#define memcpy(t, f, n)				\
	(__builtin_constant_p((n))		\
	 ? __constant_memcpy3d((t), (f), (n))	\
	 : __memcpy3d((t), (f), (n)))

> It should be possible to build with MK7 (which is an optimization
> option) and EFI (a functionality option) since they don't inherently
> conflict.  It just doesn't necessarily have to happen *right now*.

I know, technically it is doable, but do you see a K7 box with an EFI
firmware? I, at least, don't think so... :-)

Now, if you think that those optimizations could be used on other boxes
which could sport EFI, then that's a whole another question...

-- 
Regards/Gruss,
    Boris.