From: David Miller <davem@davemloft.net>
To: drepper@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: sendmmsg: put_user vs __put_user
Date: Sat, 31 Mar 2012 17:27:10 -0400 (EDT) [thread overview]
Message-ID: <20120331.172710.540592519617177028.davem@davemloft.net> (raw)
In-Reply-To: <CAOPLpQewA-AduBudgH5FK6Kz_=nHv6eFhGD29TkAosPTdP4ZHg@mail.gmail.com>
From: Ulrich Drepper <drepper@gmail.com>
Date: Sat, 31 Mar 2012 08:30:25 -0400
> On Fri, Mar 30, 2012 at 20:51, David Miller <davem@davemloft.net> wrote:
>> Compat processes are not able to generate virtual addresses anywhere
>> near the range where the kernel resides, so the address range
>> verification done by put_user() is completely superfluous and
>> therefore not necessary. The normal exception handling done by the
>> access is completely sufficient.
>
> I was more thinking about the effects of might_fault() then additional tests.
This is very clearly in a context where locks are not held and sleeping
would be fine, so I don't see any value in that either.
next prev parent reply other threads:[~2012-03-31 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 13:36 Ulrich Drepper
2012-03-31 0:51 ` David Miller
2012-03-31 12:30 ` Ulrich Drepper
2012-03-31 21:27 ` David Miller [this message]
2012-04-06 0:14 ` Andy Lutomirski
2012-04-06 1:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331.172710.540592519617177028.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drepper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®