From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755640Ab2DCWSh (ORCPT ); Tue, 3 Apr 2012 18:18:37 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:38887 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755546Ab2DCWSg (ORCPT ); Tue, 3 Apr 2012 18:18:36 -0400 Date: Tue, 03 Apr 2012 18:18:30 -0400 (EDT) Message-Id: <20120403.181830.799733266830291210.davem@davemloft.net> To: joe@perches.com Cc: jdmason@kudzu.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] vxge: Convert macro to inline function From: David Miller In-Reply-To: <1333491271.2695.20.camel@joe2Laptop> References: <1333489992.2695.17.camel@joe2Laptop> <20120403.175837.1897033408784057713.davem@davemloft.net> <1333491271.2695.20.camel@joe2Laptop> X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Tue, 03 Apr 2012 15:18:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Tue, 03 Apr 2012 15:14:31 -0700 > Convert the macro to inline function to check the arguments. > > Signed-off-by: Joe Perches > --- >> Longer term I'd much rather see this turned into an inline >> function with proper type checking etc. > > Something like this? Yep.