From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: sudhakar <sudhakar@fb.com>
Cc: <linux-serial@vger.kernel.org>, <alan@linux.intel.com>,
<gregkh@linuxfoundation.org>, <dan.j.williams@intel.com>,
<nhan.h.mai@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] 8250_pci: Replace commits 448ac154 and e86ff4a
Date: Tue, 3 Apr 2012 21:58:32 +0100 [thread overview]
Message-ID: <20120403215832.0520f93d@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <4F7B52D8.101@fb.com>
On Tue, 3 Apr 2012 12:43:20 -0700
sudhakar <sudhakar@fb.com> wrote:
>
> From: Sudhakar Mamillapalli <sudhakar@fb.com>
>
>
> The following commits don't completely fix the KT serial missing
> interrupt problems. So they have been replaced instead by
> enabling serial backup timer. The iir-once + msi tried approach tried
> to enforce one read of the iir per THRE event, but its defeated by any
> other event occurring at the wrong time, particularly MSR events.
>
> 448ac15 serial/8250_pci: setup-quirk workaround for the kt serial controller
> e86ff4a serial/8250_pci: init-quirk msi support for kt serial controller
These are already in tree. If you are reversing them and adding a
different fix then please post the series as
- two revert patches exactly reverting the two commits
- a follow on patch or two adding the replacement
That makes it much easier to review and much more obvious. It also helps
make testing simpler.
Alan
next prev parent reply other threads:[~2012-04-03 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 19:43 sudhakar
2012-04-03 20:09 ` Williams, Dan J
2012-04-03 20:58 ` Alan Cox [this message]
2012-04-09 16:47 ` Greg KH
2012-04-09 16:53 ` Williams, Dan J
2012-04-09 17:48 ` Greg KH
2012-04-09 17:59 ` Williams, Dan J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403215832.0520f93d@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nhan.h.mai@intel.com \
--cc=sudhakar@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome